Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace frozen crypto/pkcs12 library with software.sslmate.com/src/go-pkcs12 #1375

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Hermsi1337
Copy link

While playing around with cfssl a bit, I've noticed that its not always possible to decode .p12- or .pfx-files due to the following error:

unknown digest algorithm 2.16.840.1.101.3.4.2.1

While doing some research on this, I've found out, that the standard crypto/pkcs12-pkg is currently in a somewhat frozen state:
golang/go#62375

This PR suggests replacing the (currently) frozen crypto/pkcs12 with the drop-in-replacement https://github.com/SSLMate/go-pkcs12.

I also had to rework the caCertificate-Handling a bit by using DecodeChain instead of Decode, since its possible that the provided pfxData may also include the ca-certificate chain which would lead to an error when passed to a simple Decode.

Let me know what you think.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant