Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.12 and drop EOL 3.6 and 3.7 #514

Closed
wants to merge 4 commits into from

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Sep 14, 2023

The second Python 3.12 release candidate is out! 🚀

Call to action

We strongly encourage maintainers of third-party Python projects to prepare their projects for 3.12 compatibilities during this phase, and where necessary publish Python 3.12 wheels on PyPI to be ready for the final release of 3.12.0.

See also https://dev.to/hugovk/help-test-python-312-beta-1508/


Python 3.6 and 3.7 are EOL and no longer receiving security updates (or any updates) from the core Python team.
image

https://devguide.python.org/versions/

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (0f330b6) 83.28% compared to head (99ed86f) 81.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #514      +/-   ##
==========================================
- Coverage   83.28%   81.89%   -1.39%     
==========================================
  Files           4        4              
  Lines         718      674      -44     
  Branches      157      148       -9     
==========================================
- Hits          598      552      -46     
- Misses         95      109      +14     
+ Partials       25       13      -12     
Files Coverage Δ
cloudpickle/compat.py 100.00% <100.00%> (+30.00%) ⬆️
cloudpickle/cloudpickle_fast.py 91.33% <50.00%> (-0.11%) ⬇️
cloudpickle/cloudpickle.py 72.75% <60.00%> (-3.64%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean-up. This looks good to me. The only problem is the flake8 diff failure, but it looks unrelated to this. Let me try to investigate.

@ogrisel
Copy link
Contributor

ogrisel commented Oct 10, 2023

I found more code to clean-up based on the test coverage report. This work is ongoing at # #517.

@ogrisel ogrisel closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants