feat: lower FSharp.Core requirements #7
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @cmeeren,
This PR is a suggestion I choose to make it via a PR instead of an issue because it is easier to showcase the impacted code.
I am currently exploring writing test for .NET and found your library. While giving it a try, I had this warning:
This is happening because when creating a library I make FSharp.Core requirements as low as possible and in general I use FSharp.Core 5.0.2 because it has most of the goodies that are needed now days.
I am following the recommendation from F# Compiler Guide:
In my projects, I am using central package management which allows to handle versions for the packages at a single place instead of having to update each project individually. Because of these 2 reasons, I am getting the warning mentioned above when adding Faqt.
While looking at Faqt code, I discovered that there was only 1 place which needed a more recent version of FSharp.Core so I think it can be good to make the proposed change. It also means that Faqt can be used by a wider set of project without requirement then to depends on a newer version of FSharp.Core.