-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options to change the main page design #837
Open
milanlakhani
wants to merge
4
commits into
cncf:master
Choose a base branch
from
milanlakhani:milan/layout
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for landscapeapp failed.
|
milanlakhani
force-pushed
the
milan/layout
branch
from
July 26, 2022 16:02
21974a4
to
302e7fd
Compare
milanlakhani
force-pushed
the
milan/layout
branch
3 times, most recently
from
November 15, 2022 21:48
816bd9d
to
1c7c240
Compare
big_picture_label_color and big_picture_label_type are optionally configurable in settings.yml in the relations section. display_name is an item specific config which is optionally set in landscape.yml below an item's name. Signed-off-by: Milan Lakhani <[email protected]>
…e set Signed-off-by: Milan Lakhani <[email protected]>
Adds an alternative_layout flag that gives an option for a different design of the landscape main page. This can be set as true in settings.yml under big_picture and main. Signed-off-by: Milan Lakhani <[email protected]>
Signed-off-by: Milan Lakhani <[email protected]>
milanlakhani
force-pushed
the
milan/layout
branch
from
December 1, 2022 14:22
1c7c240
to
1a493e4
Compare
@AndreyKozlov1984 this is quite a nice one but maybe it's too much change? I expanded on the description |
They're just optional configurations so don't actually affect anything if none of the configs are set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to Issue #834
For items with the
large_item
flag, this PR adds configurable options to change the label text and label colour. It also provides analternative_layout
option which offers a different design scheme for categories on the main page.The new completely optional config options here are
big_picture_label_color
,big_picture_label_type
(ie whether the label is the project or item name),display_name
(this allows a different display name to be set when the label type is item name) andalternative_layout
. The display name also would show instead of the item name at the top of the item's dialog box. All of these configs are completely optional.big_picture_label_color
simply sets the colour of the large item label.big_picture_label_type
relates to what the label text actually shows - if set toItem
oritem
the label shows the item name rather than the item project (in the future more values other thanitem
can be added to make the text something different).big_picture_label_color
andbig_picture_label_type
would go in settings.yml, in relation -> values, like so:display_name would go in landscape.yml below the name for an item, like so:
So if the landscape without any of the new configs set looks like this:
When
alternative_layout
is set to true andbig_picture_label_color
andbig_picture_label_type
are set, the above landscape can change to look like this:Notice that the labels for the large items are larger and can be adjusted to show the item name instead of the project name, or any custom text and color.
CC @michaelmoss @awright @danielsilverstone-ct @GeriG966 @abhi0469