Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to change the main page design #837

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

milanlakhani
Copy link
Contributor

@milanlakhani milanlakhani commented Jul 26, 2022

Relates to Issue #834

For items with the large_item flag, this PR adds configurable options to change the label text and label colour. It also provides an alternative_layout option which offers a different design scheme for categories on the main page.

The new completely optional config options here are big_picture_label_color, big_picture_label_type (ie whether the label is the project or item name), display_name (this allows a different display name to be set when the label type is item name) and alternative_layout. The display name also would show instead of the item name at the top of the item's dialog box. All of these configs are completely optional.

big_picture_label_color simply sets the colour of the large item label. big_picture_label_type relates to what the label text actually shows - if set to Item or item the label shows the item name rather than the item project (in the future more values other than item can be added to make the text something different). big_picture_label_color and big_picture_label_type would go in settings.yml, in relation -> values, like so:

# settings.yml
relation:
  values:
    big_picture_label_color: black
    big_picture_label_type: Item

display_name would go in landscape.yml below the name for an item, like so:

# landscape.yml
landscape:
  - category:
    subcategories:
      - subcategory:
        name: ...
        items:
          - item:
            name: ...
            display_name: ...

So if the landscape without any of the new configs set looks like this:
Screenshot from 2022-07-26 14-13-46

When alternative_layout is set to true and big_picture_label_color and big_picture_label_type are set, the above landscape can change to look like this:
Screenshot from 2022-07-26 14-13-06
Notice that the labels for the large items are larger and can be adjusted to show the item name instead of the project name, or any custom text and color.

CC @michaelmoss @awright @danielsilverstone-ct @GeriG966 @abhi0469

@milanlakhani milanlakhani changed the title Milan/layout Add options to change the main page design Jul 26, 2022
@netlify
Copy link

netlify bot commented Jul 26, 2022

Deploy Preview for landscapeapp failed.

Name Link
🔨 Latest commit 1a493e4
🔍 Latest deploy log https://app.netlify.com/sites/landscapeapp/deploys/6388b8c30958630008d01af9

big_picture_label_color and big_picture_label_type are optionally
configurable in settings.yml in the relations section. display_name is
an item specific config which is optionally set in landscape.yml
below an item's name.

Signed-off-by: Milan Lakhani <[email protected]>
Adds an alternative_layout flag that gives an option for a different
design of the landscape main page. This can be set as true in
settings.yml under big_picture and main.

Signed-off-by: Milan Lakhani <[email protected]>
@milanlakhani
Copy link
Contributor Author

@AndreyKozlov1984 this is quite a nice one but maybe it's too much change? I expanded on the description

@milanlakhani
Copy link
Contributor Author

They're just optional configurations so don't actually affect anything if none of the configs are set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant