Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up after reading contributing docs #1255

Merged
merged 4 commits into from
May 2, 2024
Merged

Conversation

nameloCmaS
Copy link
Contributor

@nameloCmaS nameloCmaS commented Feb 28, 2024

This pull request does the below:

  1. Tidies the contribute docs generally (updated some out of date links, added some more detail to code examples, updated RST syntax to use code-block in place of highlight descriptor, corrected tox test environments).
  2. Changed Firefox example path from canary to firefox_nightly.
  3. Removed old rst file referencing install of PyQt4 for now unused driver.
  4. Removed link to non-existent rst in old releases.
  5. Updated Selenium keys as example code does not work as mentioned in issue Cannot send characters directly to the browser #1147.
  6. Corrected tutorial to ref second btnK named element as didn't work.
  7. Added missing lint environment to tox.ini

For item 7 I have rewritten the tox.ini file but will raise an issue for bigger changes (#1256).

Fixes some errors with build docs, some example code didn't run, general tidy up.
splinter/driver/webdriver/__init__.py Outdated Show resolved Hide resolved
docs/contribute/contribute.rst Show resolved Hide resolved
Copy link
Contributor Author

@nameloCmaS nameloCmaS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed change to code as requested.

@nameloCmaS nameloCmaS mentioned this pull request Mar 1, 2024
@fsouza fsouza merged commit dbf5ac2 into cobrateam:master May 2, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants