Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup find element docs, add browser.find() info #1298

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

jsfehler
Copy link
Collaborator

No description provided.

@jsfehler jsfehler requested a review from fsouza June 13, 2024 13:51
Copy link
Contributor

@fsouza fsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments, non-blocking.

This will stay in effect for the entire life cycle of your script, unless
explicitly changed again.

Although ``browser.find()`` has a less implicit naming structure, it's also less verbose.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explicit? (or implicit without "less"?)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Fixed

Find Links
==========

To target only links on a page, the ``links`` namespace provides find 4 methods.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To target only links on a page, the ``links`` namespace provides find 4 methods.
To target only links on a page, the ``links`` namespace provides 4 find methods.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Fixed

@jsfehler jsfehler merged commit ac5bb1c into cobrateam:master Jun 13, 2024
26 checks passed
@jsfehler jsfehler deleted the element_docs branch June 13, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants