Remove more variables found by oxlint no-unused-vars

cockpit-project · Aug 30, 2024 · 221f823 · 221f823
1 parent 18db1d6
commit 221f823
Show file tree

Hide file tree

Showing 11 changed files with 12 additions and 28 deletions.
diff --git a/src/components/vm/disks/diskAdd.jsx b/src/components/vm/disks/diskAdd.jsx
@@ -761,7 +761,6 @@ const AddDiskModalFooter = ({
                 target: diskParams.target,
                 permanent: diskParams.permanent,
                 hotplug,
-                vmName: vm.name,
                 vmId: vm.id,
                 cacheMode: diskParams.cacheMode,
                 busType: diskParams.busType,
@@ -785,7 +784,6 @@ const AddDiskModalFooter = ({
             target: diskParams.target,
             permanent: diskParams.permanent,
             hotplug,
-            vmName: vm.name,
             vmId: vm.id,
             cacheMode: diskParams.cacheMode,
             shareable: volume && volume.format === "raw" && isVolumeUsed[diskParams.existingVolumeName].length > 0,

diff --git a/src/components/vm/disks/vmDiskColumns.jsx b/src/components/vm/disks/vmDiskColumns.jsx
@@ -84,7 +84,7 @@ DiskSourceCell.propTypes = {
     idPrefix: PropTypes.string.isRequired,
 };
 
-export const DiskExtras = ({ idPrefix, cache, type, io, discard, serial, errorPolicy }) => {
+export const DiskExtras = ({ idPrefix, cache, type, io, discard, serial }) => {
     const addOptional = (chunks, value, type, descr) => {
         if (value) {
             chunks.push(
@@ -112,7 +112,6 @@ DiskExtras.propTypes = {
     cache: PropTypes.string,
     io: PropTypes.string,
     discard: PropTypes.string,
-    errorPolicy: PropTypes.string,
     idPrefix: PropTypes.string.isRequired,
 };
 
@@ -121,7 +120,6 @@ export const RemoveDiskModal = ({ vm, disk, storagePools, onAddErrorNotification
         return domainDetachDisk({
             connectionName: vm.connectionName,
             id: vm.id,
-            name: vm.name,
             target: disk.target,
             live: vm.state === 'running',
             persistent: vm.persistent,

diff --git a/src/components/vm/disks/vmDisksCard.jsx b/src/components/vm/disks/vmDisksCard.jsx
@@ -227,8 +227,7 @@ export const VmDisksCard = ({ vm, vms, disks, renderCapacity, supportedDiskBusTy
                                    type={disk.driver.type}
                                    io={disk.driver.io}
                                    discard={disk.driver.discard}
-                                   serial={disk.serial}
-                                   errorPolicy={disk.driver.errorPolicy} />
+                                   serial={disk.serial} />
             });
         }
 

diff --git a/src/components/vm/filesystems/vmFilesystemsCard.jsx b/src/components/vm/filesystems/vmFilesystemsCard.jsx
@@ -93,14 +93,13 @@ export const VmFilesystemsCard = ({ connectionName, vmName, vmState, filesystems
     );
 };
 
-export const VmFilesystemActions = ({ connectionName, objPath, vmName, vmState }) => {
+export const VmFilesystemActions = ({ connectionName, vmName, vmState }) => {
     const Dialogs = useDialogs();
     const idPrefix = `${vmId(vmName)}-filesystems`;
 
     function open() {
         Dialogs.show(<VmFilesystemAddModal connectionName={connectionName}
-                                           vmName={vmName}
-                                           objPath={objPath} />);
+                                           vmName={vmName} />);
     }
 
     const addButton = (
@@ -115,7 +114,7 @@ export const VmFilesystemActions = ({ connectionName, objPath, vmName, vmState }
     return vmState == 'shut off' ? addButton : <Tooltip content={_("Adding shared directories is possible only when the guest is shut off")}>{addButton}</Tooltip>;
 };
 
-const VmFilesystemAddModal = ({ connectionName, objPath, vmName }) => {
+const VmFilesystemAddModal = ({ connectionName, vmName }) => {
     const Dialogs = useDialogs();
     const [additionalOptionsExpanded, setAdditionalOptionsExpanded] = useState(false);
     const [dialogError, setDialogError] = useState();
@@ -143,7 +142,6 @@ const VmFilesystemAddModal = ({ connectionName, objPath, vmName }) => {
             })
                     .then(() => domainCreateFilesystem({
                         connectionName,
-                        objPath,
                         vmName,
                         source,
                         target: mountTag,

diff --git a/src/components/vm/hostdevs/hostDevAdd.jsx b/src/components/vm/hostdevs/hostDevAdd.jsx
@@ -78,7 +78,7 @@ function devicesHaveAChild(selectableDevices) {
     return Object.values(all).sort(a => a.hasChildren ? 1 : -1);
 }
 
-const DevRow = ({ idPrefix, type, selectableDevices, setSelectableDevices }) => {
+const DevRow = ({ idPrefix, selectableDevices, setSelectableDevices }) => {
     function getSource(nodeDev, id) {
         const cells = [];
         if (nodeDev.capability.type === "usb_device") {
@@ -218,7 +218,7 @@ const AddHostDev = ({ idPrefix, vm }) => {
     const body = (
         <Form isHorizontal>
             <TypeRow type={type} setType={setTypeWrapper} />
-            <DevRow idPrefix={idPrefix} type={type} selectableDevices={selectableDevices} setSelectableDevices={setSelectableDevices} />
+            <DevRow idPrefix={idPrefix} selectableDevices={selectableDevices} setSelectableDevices={setSelectableDevices} />
         </Form>
     );
 

diff --git a/src/components/vm/overview/bootOrder.jsx b/src/components/vm/overview/bootOrder.jsx
@@ -349,7 +349,7 @@ function getBootOrder(vm) {
     return bootOrder;
 }
 
-export const BootOrderLink = ({ vm, idPrefix, nodeDevices }) => {
+export const BootOrderLink = ({ vm, idPrefix }) => {
     const Dialogs = useDialogs();
 
     function open() {

diff --git a/src/components/vm/overview/cpuModal.jsx b/src/components/vm/overview/cpuModal.jsx
@@ -200,7 +200,6 @@ export const CPUModal = ({ vm, maxVcpu, models }) => {
         setIsLoading(true);
         domainSetCpuMode({
             name: vm.name,
-            id: vm.id,
             connectionName: vm.connectionName,
             mode: cpuMode,
             model: cpuModel

diff --git a/src/components/vm/overview/vmOverviewCard.jsx b/src/components/vm/overview/vmOverviewCard.jsx
@@ -100,7 +100,7 @@ class VmOverviewCard extends React.Component {
     }
 
     render() {
-        const { vm, vms, nodeDevices, libvirtVersion } = this.props;
+        const { vm, vms, libvirtVersion } = this.props;
         const idPrefix = vmId(vm.name);
 
         const autostart = (
@@ -191,8 +191,7 @@ class VmOverviewCard extends React.Component {
                         <DescriptionListGroup>
                             <DescriptionListTerm>{_("Boot order")}</DescriptionListTerm>
                             <DescriptionListDescription id={`${idPrefix}-boot-order`}>
-                                <BootOrderLink vm={vm} idPrefix={idPrefix}
-                                                   nodeDevices={nodeDevices} />
+                                <BootOrderLink vm={vm} idPrefix={idPrefix} />
                             </DescriptionListDescription>
                         </DescriptionListGroup>
 
@@ -289,7 +288,6 @@ VmOverviewCard.propTypes = {
     vms: PropTypes.array.isRequired,
     config: PropTypes.object.isRequired,
     libvirtVersion: PropTypes.number.isRequired,
-    nodeDevices: PropTypes.array.isRequired,
 };
 
 export default VmOverviewCard;
diff --git a/src/components/vm/vmDetailsPage.jsx b/src/components/vm/vmDetailsPage.jsx
@@ -118,7 +118,7 @@ export const VmDetailsPage = ({
                                   maxVcpu={vm.capabilities.maxVcpu}
                                   cpuModels={vm.capabilities.cpuModels}
                                   cpuHostModel={vm.capabilities.cpuHostModel}
-                                  nodeDevices={nodeDevices} libvirtVersion={libvirtVersion} />,
+                                  libvirtVersion={libvirtVersion} />,
         },
         {
             id: `${vmId(vm.name)}-usage`,
@@ -208,13 +208,11 @@ export const VmDetailsPage = ({
                     </>
                 ),
                 actions: <VmFilesystemActions connectionName={vm.connectionName}
-                                              objPath={vm.id}
                                               vmName={vm.name}
                                               memory={vm.memory}
                                               vmState={vm.state} />,
                 body: <VmFilesystemsCard connectionName={vm.connectionName}
                                          filesystems={vm.filesystems}
-                                         objPath={vm.id}
                                          vmName={vm.name}
                                          vmState={vm.state} />
             }

diff --git a/src/libvirtApi/domain.js b/src/libvirtApi/domain.js
@@ -125,7 +125,6 @@ export function domainAttachDisk({
     format,
     target,
     vmId,
-    vmName,
     permanent,
     hotplug,
     cacheMode,
@@ -354,7 +353,7 @@ export async function domainCreate({
     }
 }
 
-export function domainCreateFilesystem({ connectionName, objPath, vmName, source, target, xattr }) {
+export function domainCreateFilesystem({ connectionName, vmName, source, target, xattr }) {
     const options = { err: "message" };
     if (connectionName === "system")
         options.superuser = "try";
@@ -478,7 +477,6 @@ export function domainDesktopConsole({
 }
 
 export async function domainDetachDisk({
-    name,
     connectionName,
     id: vmPath,
     target,
@@ -892,7 +890,6 @@ export function domainSendNMI({
 
 export function domainSetCpuMode({
     name,
-    id: objPath,
     connectionName,
     mode,
     model,

diff --git a/src/libvirtApi/storageVolume.js b/src/libvirtApi/storageVolume.js
@@ -44,7 +44,6 @@ export async function storageVolumeCreateAndAttach({
     format,
     target,
     vmId,
-    vmName,
     permanent,
     hotplug,
     cacheMode,