Makefile: Update Cockpit lib to e8cf93050356f; fix adding disks to transient VM, and lots of test bugs #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
changed the title
allisonkarlitskaya
pushed a commit
that referenced
this pull request
Aug 22, 2024
allisonkarlitskaya
force-pushed
the
cockpit-lib-update-cockpit-lib-20240822-023242
branch
from
cf2069d
to
d0b5402
Compare
|
The |
|
Most failures are shallow (unclosed dialogs and such). TestMachinesDisks.testAddDiskDirPool is much harder: It's a race condition which happens to work most of the time with Chromium, but if you wait/sit after the What's not obvious is how to properly wait for the |
martinpitt
pushed a commit
that referenced
this pull request
Aug 22, 2024
martinpitt
force-pushed
the
cockpit-lib-update-cockpit-lib-20240822-023242
branch
from
d0b5402
to
5960bb9
Compare
|
Not done yet, but pushing what I have as I need to run out for a bit. |
Selecting a new action from the main page while a dialog is open only worked with our `ph_mouse()` cheat, not with proper clicks.
Otherwise the list obscures the dialog's action buttons, so they are not clickable (only with `ph_mouse()` which circumvents the browser).
martinpitt
pushed a commit
that referenced
this pull request
Aug 22, 2024
martinpitt
force-pushed
the
cockpit-lib-update-cockpit-lib-20240822-023242
branch
from
5960bb9
to
e794803
Compare
|
Meh, this is a completely stupid failure: That's nonsense -- plenty of other methods in the same class use |
The disk kebabs keep jumping around while the Disk table initializes and re-renders, which is a race condition when trying to click on them with the actual browser mouse. So robustify the tests to wait for the table to be complete. This mitigates the issue, and also provides some nice extra validation. This was already done in a few places, generalize this into a `waitDisks()` helper. Unfortunately in some cases waiting for the entries is still not enough, but I can't figure out what else to wait on.. Do an extra sleep for the table to settle down.
martinpitt
pushed a commit
that referenced
this pull request
Aug 22, 2024
martinpitt
force-pushed
the
cockpit-lib-update-cockpit-lib-20240822-023242
branch
from
e794803
to
cce3bc3
Compare
martinpitt
pushed a commit
that referenced
this pull request
Aug 22, 2024
martinpitt
force-pushed
the
cockpit-lib-update-cockpit-lib-20240822-023242
branch
from
cce3bc3
to
a07c76a
Compare
|
phew I figured out |
TestMachinesDisks.testAddDiskDirPool's "transient VM" test case ommediately opened the "Add Disk" dialog after undefining the VM. This was a race condition which the test actually "won" in most cases: The `UNDEFINED` event did not yet bubble through the UI, so the "Add Disk" dialog still thought that the VM was persistent. Fix that by waiting until the UI picked up the event and considers the VM transient. This exposed a bug in the dialog's fill() function: It tried to check the value of the "Permanent" checkbox, but that doesn't exist at all for transient VMs. Fix up the logic and assert the latter for transient VMs. Now that this test is working correctly, it uncovered a bug in the code: Trying to add a disk to a transient VM fails with > Requested operation is not valid: transient domains do not have any persistent config because the `persistent` state was initialized to "true". Fix that. https://issues.redhat.com/browse/RHEL-17677
martinpitt
force-pushed
the
cockpit-lib-update-cockpit-lib-20240822-023242
branch
from
a07c76a
to
504c26b
Compare
martinpitt
changed the title
martinpitt
changed the title
KKoukiou
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.