libvirtApi remove use of interfaceGetAll #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to me the file src/libvirtApi/interface.js can be removed too. |
|
Sure, thanks! This will need some more cleanup, but doing a first round of tests. (Note that nobody in the Cockpit team will be working tomorrow, so will revisit this on Monday) |
martinpitt
approved these changes
Aug 26, 2024
|
@Lunarequest I'll revert this. See the discussion in #1782 , this needs more work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is in reference to #1777,
interfaceGetAllis only used in one place and in local testing all tests still pass.GetXMLDescwould need a larger rework to drop usage but most of its usage should be fine