lib: Add path functions #20991
Merged
lib: Add path functions #20991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mvollmer
force-pushed
the
lib-path
branch
2 times, most recently
from
1db0231
to
0aa51c6
Compare
cockpituous
reviewed
Sep 11, 2024
Comment on lines
+24
to
+25
| pos -= 1; | ||
| return pos == path.length ? path : path.substr(0, pos); |
There was a problem hiding this comment.
These 2 added lines are not executed by any test.
There was a problem hiding this comment.
So hmm this coverage does not account for the qunit coverage right? Feature, Bug ;-)
Would be awesome to merge them but sounds tedious so back to reviewing :)
| if (pos < 0) | ||
| return "."; | ||
| else if (pos == 0) | ||
| return "/"; |
There was a problem hiding this comment.
This added line is not executed by any test.
jelly
approved these changes
Sep 16, 2024
Comment on lines
+24
to
+25
| pos -= 1; | ||
| return pos == path.length ? path : path.substr(0, pos); |
There was a problem hiding this comment.
So hmm this coverage does not account for the qunit coverage right? Feature, Bug ;-)
Would be awesome to merge them but sounds tedious so back to reviewing :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.