Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolved: toggling cards pressing shortcut #1847

Draft
wants to merge 1,489 commits into
base: master
Choose a base branch
from

Conversation

pg2511
Copy link
Member

@pg2511 pg2511 commented Nov 22, 2023

Resolving Issue: #1845
Hello, @ImprovedTube , this PR is created to resolve the issue of toggling cards coming up at the end of youtube video.

Here is a detailed video as a result of changes done:
toggle cards shortcut.webm

How it works:

  • Go to Shortcuts
  • Create a shortcut for Toggle cards
  • Now play any youtube video
  • When toggling cards show, press shortcut it will hide, press again they will show (Toggling functionality perfectly working now)

Have a look, and please merge this PR, feel free to share suggestions if any.

ImprovedTube and others added 13 commits November 18, 2023 22:16
fixed error when querySelecetors don't find their target (fixed chaining of `?.`)
formatting/refactoring and removed title change (gets changed on its own)
formatting and removed title
fixed variable name and removed title (also added a comment)
- fixed when opening video and playlist when video is >200th of playlist it starts at first entry (←normal), but at the start-time where the initial video was at, which might result in the video to skip to the end and immediately play the next (←problem)
- added the URL-less popup call to playlist button (to update popup window to a URL-less popup)
@pg2511
Copy link
Member Author

pg2511 commented Nov 23, 2023

If it seems fine to you, @ImprovedTube - can you merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Solution exists (Here or 3rd party) Exists in any extension, userscript, webapp or app. Written in JS or not
Projects
None yet
Development

Successfully merging this pull request may close these issues.