IT/1959 Loop/Repeat Parity

[kjonathan024]

Improved the sync of the repeat and loop buttons to be visually and functionally linked when the user turns both buttons on. Before, I noticed that when one was set to on and the other was then added, the visual indicators of if the video would loop or not was indiscernable. I fixed this by detecting if the other button was active and then setting their opacities to be the same based on the current setting of the video (if looping or not). I did this through the onClick functions for each button respectfully, as well as adding an if statement check when the button is first added to ensure it is visually and functionally in sync.

[ImprovedTube]

hi @kjonathan024! thank you!
'.improvedtube-player-button' must be the group of all our buttons below the player? (not only the loop button)

---

querySelector by class can be "slow. (Might only be worth considering because it is enabled by default and can run billions of times). Generally one could use getElementById. But we can also just call it on click only, and then we can specifically check our settings in that are loaded already, to know if the other button is enabled ( if (this.storage.player_repeat_button === true) { and if ( this.storage.below_player_loop !== false) { respectively. - Or both buttons could share the same .css class, and change the class' opacity on click.

---

just added to #1504 :

• separate the 'always repeat'-feature from the buttons (in our function & GUI), so that it works alone. ImprovedTube.alwaysRepeat = function () { if(this.storage.player_always_repeat === true) .

[kjonathan024]

hi @ImprovedTube ! Thank you for your comments, I have made appropriate changes based on your recommendations.

[ImprovedTube]

hi! thanks @kjonathan024, hope you like the 4 commits above and they don't break anything.

just added to #1504 :

• separate the always repeat switch from the buttons (in our function & GUI), so that it works alone. ImprovedTube.alwaysRepeat = function () { if(this.storage.player_always_repeat === true)

• allow repeating by category only like music or education (implemented at our speed-watching feature only yet. but many of our features might consider such data in future)
• remember looping (once or unlimited) for each video
• allow sticky-on with rightclick (faster than finding always repeat button in our list of features) compare <video> Player buttons to be added</video> #1445

[kjonathan024]

@ImprovedTube Thank you for your guidance and support! Glad to be able to contribute to your project. From the testing that I did, it seems that I remedied any small bugs that happened because of the change.

[JourneyOver]

I think this pr/commit broke something in 4.641 (my extension just updated to 4.641 (from version 4.615) as of an hour ago and that is when I started to notice the following issue) as now any videos seem to just loop when it gets to the end of the video even though repeat/loop video is turned off in the settings...

I turned on the option to show the loop button under the video and any videos I go to seem to have the icon light up
and the video loops back to the beginning again even though I have nothing for looping/repeating videos turned on at all in the settings.. even if I click the icon and turn it off if I refresh the page or go to another video it automatically seems to turn itself back on again.

Edit: Downgraded back to 4.615 (moving all the files from 4.615 to 4.641 and replacing everything) and the issue stops... idk if it is this pr exactly but since this PR was to do with loop/repeat I am in my mind thinking it has something to at least do with it.

[deadpixel134]

I just encountered the same issue.
Turning off this extension makes the problem go away.