Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OAS Specifications for v2 API #397

Merged
merged 11 commits into from
Sep 16, 2024
Merged

Add OAS Specifications for v2 API #397

merged 11 commits into from
Sep 16, 2024

Conversation

DMalone87
Copy link
Collaborator

@DMalone87 DMalone87 commented Jun 5, 2024

This PR adds specifications that represent the next edition of the NPDI API. This spec will help guide future development internally and potential integrations with partner organizations.

This also includes a script that converts the OAS schemas into Pydantic models that can be used to validate alterations to the database. This is required for the update to the database (#407) which will remove SQL Alchemy and the current schema generation logic. This will also support the work on the ETL pipeline in the Scraper repo.

- officers
- agencies
- partners
- litigation
- common schemas for error and pagination
@DMalone87 DMalone87 self-assigned this Aug 21, 2024
@DMalone87 DMalone87 added enhancement New feature or request backend priority documentation Improvements or additions to documentation and removed backend labels Aug 21, 2024
@DMalone87
Copy link
Collaborator Author

The current version of the API docs can be found on Readme.com.

- Includes Pydantic models for the main OAS schemas
- Also updated ID -> UID to comply with Neo4j reqs
- Associate officers with units, not agencies
- Add website url to review boards
- Differenciate command posts from standard officer employment
- Rename officer associations (investigators, commanders, etc.)
Update OAS README
@DMalone87 DMalone87 marked this pull request as ready for review September 5, 2024 15:45
- Enthinicy enums added. Choices are based on the US DOI standards for
  observeer collected demographic data.
  https://www.doi.gov/pmb/eeo/directives/race-data
- Added dates to Unit and Penalty.
- UID added to penalties
@DMalone87 DMalone87 merged commit 008334f into main Sep 16, 2024
3 checks passed
@DMalone87 DMalone87 deleted the dmalone/v2-oas branch September 16, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant