fixup! feat(database): add trait to implement nested transactions via…

… savepoints
codeigniter4 · Apr 29, 2024 · 82c06cd · 82c06cd
1 parent b044e1b
commit 82c06cd
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/system/Database/SavepointsForNestedTransactions.php b/system/Database/SavepointsForNestedTransactions.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /**
  * This file is part of CodeIgniter 4 framework.
  *
@@ -16,12 +18,12 @@ trait SavepointsForNestedTransactions
     /**
      * Generates the SQL for managing savepoints, which
      * are used to support nested transactions with SQLite3
-     *
-     * @param mixed $savepoint
      */
-    private function _savepoint($savepoint, string $action = ''): string
+    private function _savepoint(int $savepoint, string $action = ''): string
     {
-        return ($action === '' ? '' : $action . ' ') . 'SAVEPOINT `__ci4_' . $savepoint . '`';
+        $savepointIdentifier = $this->escapeIdentifier('__ci4_savepoint_' . $savepoint . '__');
+
+        return ($action === '' ? '' : $action . ' ') . 'SAVEPOINT ' . $savepointIdentifier;
     }
 
     /**