Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: PHPStan Cache no type specified #7756

Merged
merged 1 commit into from
Aug 2, 2023
Merged

docs: PHPStan Cache no type specified #7756

merged 1 commit into from
Aug 2, 2023

Conversation

ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Jul 31, 2023

Description
See #7731

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the stale Pull requests with conflicts label Aug 1, 2023
@kenjis
Copy link
Member

kenjis commented Aug 1, 2023

Please rebase to resolve conflict.

Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see 8 deletes in baseline but only 2 files are changed (CacheInterface and MockCache). It seems the change in CacheInterface affects the handlers but why is MockCache still annotated?

@ddevsr ddevsr removed the stale Pull requests with conflicts label Aug 2, 2023
@ddevsr ddevsr requested a review from kenjis August 2, 2023 01:32
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kenjis kenjis merged commit 06e5089 into codeigniter4:develop Aug 2, 2023
51 checks passed
@ddevsr ddevsr deleted the cache-type-specified branch August 2, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants