Always include annotations in the Deployment object #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checksum in annotations ensures that the pod restart when an object is
updated. Previosuly, checksums were not included when there were no other
annotations on the object, so they had no effect.
Instead, always include annotations with at least the checksums, so they
are be used regardless.
Fixes: 45bed51a ("Ensure the pod restarts when the K8s secret with the config is updated")
Signed-off-by: Pablo Vigo <[email protected]>
em-
approved these changes
Jan 26, 2024
| annotations: | ||
| checksum/secret: {{ include (print $.Template.BasePath "/lava-token-secret.yaml") . | sha256sum }} | ||
| {{- with .Values.podAnnotations }} |
There was a problem hiding this comment.
I hope @sjoerdsimons will not mind the weird indentation here, but in that case we can fix it later, doing the patch this way makes it as clear as possible. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checksum in annotations ensures that the pod restart when an object is updated. Previosuly, checksums were not included when there were no other annotations on the object, so they had no effect.
Instead, always include annotations with at least the checksums, so they are be used regardless.
Fixes: 45bed51a ("Ensure the pod restarts when the K8s secret with the config is updated")