[DBC]Add support for multiple signal multiplexor values #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@collin80 May I ask your opinion about this PR? I can fix the conflicts if there is interest in merging it. |
|
I'm way behind in merging PRs but I'm back to looking at this. I'm pretty sure I'll be merging it in soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vector CANDB++ supports adding multiple multiplexor values:
This translates to the following line in DBC:
The current regex was unable to match these lines, so this PR fixes it.
As it turned out the SavvyCAN has a more comprehensive DBC support than I thought so I went through and modified all the bits and pieces necessary to support multiple multiplex ranges.