Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gs_usb support in Windows build to support CANable, CAN Bus Debugger CANtact devices #835

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

BennyEvans
Copy link
Contributor

As discussed in Issue #238 this PR adds support for devices utilising the gs_usb protocol on Windows.

The dll that supports the protocol is licenced under the LGPL and so is appropriately compiled separately and linked dynamically. The source for the dll is available here: https://github.com/BennyEvans/candle_dll

I've tested with CANable and CAN Bus Debugger devices and with both at the same time without issue.

For transparency sake, it's worth noting that I'm the main developer of the CAN Bus Debugger device.

Let me know if there is anything that needs to be modified. I think it'll be great to add this support to the application.

Thanks again!
Ben

@BennyEvans BennyEvans mentioned this pull request Aug 27, 2024
@BennyEvans
Copy link
Contributor Author

BennyEvans commented Aug 27, 2024

It's also worth noting that the DLL/licence will need to be copied into the appropriate place to be distributed with a Windows release.

@collin80
Copy link
Owner

Thanks, I want to merge this but I'll probably hold off until I have time to also configure the continuous build to package the DLL properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants