fix msvc build

recipes/readstat/all/conandata.yml

@@ -1,4 +1,6 @@
 sources:
   "1.1.9":
-    url: "https://github.com/WizardMac/ReadStat/releases/download/v1.1.9/readstat-1.1.9.tar.gz"
-    sha256: "3a232b9e852d10173e2f25da9155afe2e129a30d1fc6c9aac142cdc5cbfe527e"
+    - url: "https://github.com/WizardMac/ReadStat/archive/refs/tags/v1.1.9.zip"
+      sha256: "2a52026ae6e2348780060f4a769e272e0e1c04dd918b8e76d66e8c9861a81cbc"
+    - url: "https://github.com/WizardMac/ReadStat/releases/download/v1.1.9/readstat-1.1.9.tar.gz"
+      sha256: "3a232b9e852d10173e2f25da9155afe2e129a30d1fc6c9aac142cdc5cbfe527e"

recipes/readstat/all/conanfile.py

@@ -1,14 +1,14 @@
-from conan import ConanFile
+from conan import ConanFile, conan_version
 from conan.tools.build import cross_building
 from conan.tools.env import VirtualBuildEnv, VirtualRunEnv
-from conan.tools.files import apply_conandata_patches, chdir, copy, export_conandata_patches, get, rm, rmdir
+from conan.tools.files import apply_conandata_patches, copy, export_conandata_patches, get, rm, rmdir, load, save
 from conan.tools.gnu import Autotools, AutotoolsDeps, AutotoolsToolchain
 from conan.tools.layout import basic_layout
-from conan.tools.microsoft import is_msvc, NMakeDeps, NMakeToolchain
+from conan.tools.microsoft import is_msvc, MSBuildDeps, MSBuildToolchain, MSBuild, VCVars
 import os
 
 
-required_conan_version = ">=1.55.0"
+required_conan_version = ">=1.57.0"
 
 class ReadstatConan(ConanFile):
     name = "readstat"
@@ -54,20 +54,30 @@ def requirements(self):
 
     # if another tool than the compiler or autotools is required to build the project (pkgconf, bison, flex etc)
     def build_requirements(self):
-        if self._settings_build.os == "Windows":
-            self.win_bash = True
-            if not self.conf.get("tools.microsoft.bash:path", check_type=str):
-                self.tool_requires("msys2/cci.latest")
+        # if self._settings_build.os == "Windows":
+        #     self.win_bash = True
+        #     if not self.conf.get("tools.microsoft.bash:path", check_type=str):
+        #         self.tool_requires("msys2/cci.latest")
+        if self._settings_build.os == "Macos":
+            self.tool_requires("libtool/2.4.7")
 
+    def _sys_compiler(self):
+        return self.settings.compiler
+
     def source(self):
-        get(self, **self.conan_data["sources"][self.version], strip_root=True)
+        if self._sys_compiler == "msvc": # 'self.settings' access in 'source()' method was forbidden
+            get(self, **self.conan_data["sources"][self.version][0], strip_root=True)
+        else:
+            get(self, **self.conan_data["sources"][self.version][1], strip_root=True)
 
     def generate(self):
         if is_msvc(self):
-            tc = NMakeToolchain(self)
+            tc = MSBuildToolchain(self)
             tc.generate()
-            deps = NMakeDeps(self)
+            deps = MSBuildDeps(self)
             deps.generate()
+            tc = VCVars(self)
+            tc.generate()
         else:
             env = VirtualBuildEnv(self)
             env.generate()
@@ -79,20 +89,28 @@ def generate(self):
             deps = AutotoolsDeps(self)
             deps.generate()
 
+    def _msbuild_configuration(self):
+        return "Debug" if self.settings.build_type == "Debug" else "Release"
+
     def build(self):
         apply_conandata_patches(self)
         if is_msvc(self):
-            args = "readstat_i.lib READSTAT_EXPORT=-DDLL_EXPORT" if self.options.shared else "readstat.lib"
-            with chdir(self, self.source_folder):
-                self.run(f"nmake -f makefile.vc {args}")
+            msbuild = MSBuild(self)
+            msbuild.build_type = self._msbuild_configuration
+            msbuild.build(sln=os.path.join("VS17", "ReadStat.sln"))
         else:
             autotools = Autotools(self)
-            # autotools.autoreconf()
             autotools.configure()
             autotools.make()
-            
+
     def package(self):
-        copy(self, pattern="LICENSE", src=self.source_folder, dst=os.path.join(self.package_folder, "licenses"))
+        # Ensure the licenses folder exists
+        # licenses_folder = os.path.join(self.package_folder, "licenses")
+        # if not os.path.exists(licenses_folder):
+        #     os.makedirs(licenses_folder)
+        # copy(self, "NEWS", src=self.source_folder, dst=licenses_folder)
+        # upstream didn't pack license file into distribution
+        copy(self, "NEWS", src=self.source_folder, dst=os.path.join(self.package_folder, "licenses"))
         if is_msvc(self):
             copy(self, "readstat.h", src=os.path.join(self.source_folder, "headers"), dst=os.path.join(self.package_folder, "include"))
             copy(self, "*.lib", src=self.source_folder, dst=os.path.join(self.package_folder, "lib"), keep_path=False)