Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDAL: Adds option to rename shapelib's exported symbols #25176

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

JustCallMeRay
Copy link

@JustCallMeRay JustCallMeRay commented Sep 7, 2024

Summary

Changes to recipe: GDAL/>3.5 to add option to not rename shapelib symbols.

Motivation

fixes issue #25175

Details

Adds option rename_shapelib_symbols which is forwarded to the cmake option RENAME_INTERNAL_SHAPELIB_SYMBOLS


@CLAassistant
Copy link

CLAassistant commented Sep 7, 2024

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

Comment on lines 340 to 341
if (not self.options.rename_shapelib_symbols) and not self.options.with_shapelib:
raise ConanInvalidConfiguration("Must compile with shapelib to have shapelib symbols exported")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should do

if not self.options.with_shapelib:
    del self.options.rename_shapelib_symbols

in configure() instead.

Copy link
Contributor

@valgur valgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a reasonable addition to me.

The usual way of handling vendored dependencies on CCI would be to replace them with an external Conan dependency entirely, but for context to others - the use of the external Shapelib is not recommended by GDAL and also caused compilation errors the last time I tested it. OSGeo/gdal#5711

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@JustCallMeRay JustCallMeRay marked this pull request as ready for review September 11, 2024 12:48
@conan-center-bot

This comment has been minimized.

@JustCallMeRay
Copy link
Author

I don't know what to do here,
Tests fail with MISSING_DEPENDENCIES because of Arrow.
Everything is in the log but for ease of reading:
arrow/14.0.2: Compatible package ID 857a79fb7ce8d6c1950524510e775f2f0b738fe6 equal to the default package ID: Skipping it.
Followed by:
arrow/14.0.2#b2e8a6fe3ef6b6a22ffdac9c145ba9a6:857a79fb7ce8d6c1950524510e775f2f0b738fe6 - Missing
On macos clang

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 8 (73e567cb568ca5379b7714626809ba4fadd6cc49):

  • gdal/3.8.3:
    Built 18 packages out of 22 (All logs)

  • gdal/3.5.3:
    Built 20 packages out of 22 (All logs)

  • gdal/3.7.3:
    Built 18 packages out of 22 (All logs)


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 8 (73e567cb568ca5379b7714626809ba4fadd6cc49):

  • gdal/3.7.3:
    CI failed to create some packages (All logs)

    Logs for packageID 0e572d40a54518e2d76eb0b176d0844897721cc7:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=apple-clang
    compiler.cppstd=17
    compiler.libcxx=libc++
    compiler.version=13
    os=Macos
    [options]
    */*:shared=False
    
    [...]
    deprecated=True
    encryption=False
    fPIC=True
    filesystem_layer=False
    gandiva=False
    hdfs_bridgs=False
    parquet=False
    plasma=deprecated
    runtime_simd_level=max
    shared=False
    simd_level=default
    skyhook=False
    substrait=False
    with_backtrace=False
    with_boost=False
    with_brotli=False
    with_bz2=False
    with_csv=False
    with_cuda=False
    with_flight_rpc=False
    with_flight_sql=False
    with_gcs=False
    with_gflags=False
    with_glog=False
    with_grpc=False
    with_jemalloc=False
    with_json=False
    with_llvm=False
    with_lz4=False
    with_mimalloc=False
    with_openssl=False
    with_opentelemetry=False
    with_orc=False
    with_protobuf=False
    with_re2=False
    with_s3=False
    with_snappy=False
    with_thrift=False
    with_utf8proc=False
    with_zlib=False
    with_zstd=False
    [requires]
    xsimd/9.0.1#c74b1d825f467a37c2a2f03c0b022daa:da39a3ee5e6b4b0d3255bfef95601890afd80709
    
    ERROR: Missing prebuilt package for 'arrow/14.0.2'. You can try:
        - List all available packages using 'conan list "arrow/14.0.2:*" -r=remote'
        - Explain missing binaries: replace 'conan install ...' with 'conan graph explain ...'
        - Try to build locally from sources using the '--build=arrow/14.0.2' argument
    
    More Info at 'https://docs.conan.io/2/knowledge/faq.html#error-missing-prebuilt-package'
    
  • gdal/3.5.3:
    Didn't run or was cancelled before finishing

  • gdal/3.8.3:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants