-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GDAL: Adds option to rename shapelib's exported symbols #25176
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
recipes/gdal/post_3.5.0/conanfile.py
Outdated
if (not self.options.rename_shapelib_symbols) and not self.options.with_shapelib: | ||
raise ConanInvalidConfiguration("Must compile with shapelib to have shapelib symbols exported") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should do
if not self.options.with_shapelib:
del self.options.rename_shapelib_symbols
in configure()
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a reasonable addition to me.
The usual way of handling vendored dependencies on CCI would be to replace them with an external Conan dependency entirely, but for context to others - the use of the external Shapelib is not recommended by GDAL and also caused compilation errors the last time I tested it. OSGeo/gdal#5711
Addresses review comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I don't know what to do here, |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 8 (
Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping Failure in build 8 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Summary
Changes to recipe: GDAL/>3.5 to add option to not rename shapelib symbols.
Motivation
fixes issue #25175
Details
Adds option
rename_shapelib_symbols
which is forwarded to the cmake optionRENAME_INTERNAL_SHAPELIB_SYMBOLS