Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build failure using mingw #25276

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

joda01
Copy link

@joda01 joda01 commented Sep 15, 2024

Fixed missing include which allows to use getenv

Summary

Changes to recipe: lib/0.8.13

Motivation

Fix build error with mingw under Windows

Details

Added patch which adds #include <stdlib.h>


Fixed missing include which allows to use getenv
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@joda01
Copy link
Author

joda01 commented Sep 15, 2024

Relates to #25275

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor

SpaceIm commented Sep 15, 2024

Please consider joda01#1

@uilianries
Copy link
Member

@joda01 Thank you for your PR! Please, comment on the issue #4 to be able to run your PR in the CI as well.

@AbrilRBS
Copy link
Member

@joda01 please take a look into @SpaceIm PR, it's a better way to implement patches.

I do have a question: Has this issue been reported tp upstream? I'm sure they'd appreciate getting a heads-up!

@AbrilRBS AbrilRBS self-assigned this Sep 20, 2024
@joda01
Copy link
Author

joda01 commented Sep 20, 2024

@AbrilRBS Was this what you meant with better way to provide a patch?
https://github.com/conan-io/conan-center-index/pull/25276/files

When you say 'upstream', do you mean https://directory.fsf.org/wiki/Libelf?

I'm curious if anyone else has encountered similar build issues when using MingW?

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 6 (5c6229b84ca67189b92d3690a14a70637c37d2f6):

  • libelf/0.8.13:
    Built 18 packages out of 22 (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 6 (5c6229b84ca67189b92d3690a14a70637c37d2f6):

  • libelf/0.8.13:
    Built 8 packages out of 10 (All logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants