Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(*): publish oci-tar-builder binary in the ci #547

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented Apr 3, 2024

closes #524

I didn't like the fact that the published artifacts has prefixed name containerd-shim- which doesn't really fit the purpose of the oci-tar-builder.

The oci-tar-builder binary is built for each Linux, Windows and Macos-x86_64 and Macos-arm64

@jsturtevant
Copy link
Contributor

I was thinking #524 would be part of the release CI as well. Would we want to sign it too?

@Mossaka
Copy link
Member Author

Mossaka commented Apr 3, 2024

I was thinking #524 would be part of the release CI as well.

Ah yea I intend to work on another PR to add the release of the bianry as part of the release ci.

Would we want to sign it too?

sure :)

@jsturtevant
Copy link
Contributor

I didn't like the fact that the published artifacts has prefixed name containerd-shim- which doesn't really fit the purpose of the oci-tar-builder.

I think I have a preference for modify the build action to handle this verses having a separate file and process. This would give the same steps for the signing too

@jprendes
Copy link
Collaborator

jprendes commented Apr 8, 2024

I didn't like the fact that the published artifacts has prefixed name containerd-shim- which doesn't really fit the purpose of the oci-tar-builder.

I think I have a preference for modify the build action to handle this verses having a separate file and process. This would give the same steps for the signing too

I agree with both of these comments.
I would like the build action to handle both cases. We could either:

  • have a flag in the build action to conditionally add the containerd-shim- prefix, or
  • just drop the prefix, and release unprefixed artifacts for the shims as well.

I prefer the first option. I would even defer that logic to the makefile, which already has similar logic.

@Mossaka Mossaka marked this pull request as draft April 16, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Release binary for oci-tar-builder
3 participants