In a container, try to register binfmt_misc #5732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalind
added
do-not-merge/hold
No New Tests
openshift-ci
bot
added
kind/feature
nalind
force-pushed
the
binfmt-container
branch
from
0933edd
to
5f92089
Compare
rhatdan
reviewed
Sep 12, 2024
nalind
force-pushed
the
binfmt-container
branch
2 times, most recently
from
81b6534
to
4aedfc1
Compare
rhatdan
reviewed
Sep 12, 2024
| return fmt.Errorf("looking for binfmt.d configuration in %q: %w", searchDir, err) | ||
| } | ||
| for _, conf := range globs { | ||
| f, err := os.Open(conf) |
There was a problem hiding this comment.
Should we only be doing this if the image has different ARCH then the local arch?
There was a problem hiding this comment.
Sure. At that point we're too far from the CLI to make it something that can be manually controlled very easily, but then maybe we're fine without that.
nalind
force-pushed
the
binfmt-container
branch
3 times, most recently
from
f3a7b41
to
2e91082
Compare
If we're running a command in a working container whose platform doesn't match our own, attempt to register any emulators for which we find configurations of the type included in Fedora's qemu-user-static packages. Signed-off-by: Nalin Dahyabhai <[email protected]>
nalind
force-pushed
the
binfmt-container
branch
from
2e91082
to
baf91f2
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Oops, forgot I left a hold on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
If we're running a command in a working container whose platform doesn't match our own, attempt to register any emulators for which we find configurations of the type included in Fedora's qemu-user-static packages.
How to verify it
In-container tests, provided the CI node is new enough, will start being able to use emulation if they couldn't before.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?