Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .git symlinks #3631

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tdfischer
Copy link

For large projects that use google's 'repo' tool, .git is actually a symlink to somewhere else. lstat() only reads the symlink itself, not the target of the symlink, leading to errors like EISDIR: illegal operation on a directory, read

Description

That's about it. Not a lot of details here.

Motivation and Context

Fixes commitlint usage for repo-based projects (eg, yocto builds)

Usage examples

Clone a set of yocto layers using repo, try to use commitlint.

How Has This Been Tested?

Patched the module locally, commitlint started working.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

For large projects that use google's 'repo' tool, .git is actually a symlink to somewhere else. lstat() only reads the symlink itself, not the target of the symlink, leading to errors like EISDIR: illegal operation on a directory, read
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant