Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Update ci-setup.md): atualizando github action #4132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JefteCosta
Copy link

Atualizando github action para a versão 4 com node 20.x lts

Description

Essa atualização e referente a pagina de CI Setup para github Action o modelo anterio tinha um bug referente as permições da criação de pastas para instalação do nodejs

Motivation and Context

essa mudanção é nessesaria devido ao bug do yml para github action nao esta funcinando, com essa atualização ira funcionar normalmente.

Usage examples

name: CI

on: [push, pull_request]
permissions:
  contents: write
  pull-requests: write

jobs:
  commitlint:
    runs-on: ubuntu-latest

    steps:
      - uses: actions/checkout@v4
      - name: Use Node.js
        uses: actions/setup-node@v4
        with:
          node-version: '20.x'
      - name: Print versions
        run: |
          git --version
          node --version
          npm --version
          npx commitlint --version
      - name: Install commitlint
        run: |
          npm install conventional-changelog-conventionalcommits
          npm install commitlint@latest

      - name: Validate current commit (last commit) with commitlint
        if: github.event_name == 'push'
        run: npx commitlint --last --verbose

      - name: Validate PR commits with commitlint
        if: github.event_name == 'pull_request'
        run: npx commitlint --from ${{ github.event.pull_request.head.sha }}~${{ github.event.pull_request.commits }} --to ${{ github.event.pull_request.head.sha }} --verbose

How Has This Been Tested?

percebi que al ultizar o modelo do action de exemplo do site para o github estava dando erro de permição como a imagem de exemplo abaixo descreve:
image

Ao ultilizar o modelo do action descrito acima para subistitur no site do commitlint ele nao da mais esse erro nomo a imagem abaixo descreve:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Atualizando github action para a versão 4 com node 20.x lts
Copy link

codesandbox-ci bot commented Sep 1, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@escapedcat
Copy link
Member

Translation:

Updating github action to version 4 with node 20.x lts

Description

This update refers to the CI Setup page for github Action. The previous model had a bug regarding the permissions for creating folders for installing nodejs.

Motivation and Context

This change is necessary due to the bug that the yml for github action is not working. With this update, it will work normally.

@escapedcat
Copy link
Member

@knocte I guess this makes sense by now?

@knocte
Copy link
Contributor

knocte commented Sep 2, 2024

Nah, I have a better alternative, let me cook it.

@knocte
Copy link
Contributor

knocte commented Sep 4, 2024

@escapedcat bare with me, I got into a rabbit hole (maybe we're talking 5 or 6 inner levels of yak shaving), but I will eventually come out of it.

@escapedcat
Copy link
Member

@knocte no rush! Thanks for diving in! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants