allow for instantiation of FluxBurst when handle is not ready (#10)

* allow for instantiation of FluxBurst when handle is not ready we want to be able to possibly control creating the first instance (e.g., local slurm mock) and the handle may not be ready yet. Signed-off-by: vsoch <[email protected]>
converged-computing · Jul 15, 2023 · 6a2ca60 · 6a2ca60
1 parent 0022025
commit 6a2ca60
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 13 deletions.
diff --git a/.github/dev-requirements.txt b/.github/dev-requirements.txt
@@ -1,5 +1,5 @@
 pre-commit
-black
+black==23.3.0
 isort
 flake8
 pytest
diff --git a/fluxburst/handles.py b/fluxburst/handles.py
@@ -177,9 +177,21 @@ def get_job_info(self, jobid):
 
 class FluxHandle:
     def __init__(self, handle=None):
+        self._handle = handle
+
+    @property
+    def handle(self):
+        """
+        A handle propery to "handle" connection! har har.
+
+        We import Flux here to allow instantiating the client possibly
+        after the instance is created.
+        """
         import flux
 
-        self.handle = handle or flux.Flux()
+        if not self._handle:
+            self._handle = flux.Flux()
+        return self._handle
 
     def update_jobspec(self, job):
         """

diff --git a/fluxburst/utils/__init__.py b/fluxburst/utils/__init__.py
@@ -18,7 +18,7 @@
     write_json,
     write_yaml,
 )
-from .misc import choose, chunks, get_hash, mb_to_bytes, print_bytes, slugify
+from .misc import chunks, get_hash, mb_to_bytes, print_bytes, slugify
 from .terminal import (
     check_install,
     confirm_action,

diff --git a/fluxburst/utils/misc.py b/fluxburst/utils/misc.py
@@ -5,8 +5,6 @@
 
 import copy
 
-from pick import pick
-
 
 def chunks(listing, chunk_size):
     """
@@ -43,13 +41,6 @@ def mb_to_bytes(mb):
     return mb * (1048576)
 
 
-def choose(options, prompt, default_index=0):
-    """
-    Use pick to choose one of a few options, return the chosen option.
-    """
-    return pick(options, prompt, indicator="=>", default_index=default_index)
-
-
 def get_hash(obj):
     """
     Get a hash for a random object (set, tuple, list, dict)

diff --git a/fluxburst/version.py b/fluxburst/version.py
@@ -21,7 +21,6 @@
     ("rich", {"min_version": None}),
     ("oras", {"min_version": None}),
     ("requests", {"min_version": None}),
-    ("pick", {"min_version": None}),
 )
 
 INSTALL_REQUIRES_KUBERNETES = (