Metadata feature #252
Open
Metadata feature #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
suggested changes
Jan 23, 2023
| .split('\n') | ||
| .reduce((acum, item) => { | ||
| const [key, value] = item.split(DIVIDER) | ||
| return merge(acum, dotNotationToObject(key, value)) |
There was a problem hiding this comment.
why lodash and not Object.assign?
| @@ -0,0 +1,42 @@ | |||
| const merge = require('lodash/merge'); | |||
There was a problem hiding this comment.
using lodash is a CVE magnet; please use lodash.merge instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On many occasions we want to be able to add general information to our changelog, and we can obtain that metadata from git config and from the package. In this case I would like to receive feedback to make this feature safe.
This would be a subset of information that we could obtain in metadata
see template-metadata