coq-mathcomp-algebra-tactics conflicts with coq-mathcomp-word.2.0
#2452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: These are not my packages Starting with `coq-mathcomp-word` `2.0`, this package lives in the namespace `mathcomp.word`, and it includes a file `ssrZ` that conflicts with a corresponding file from `coq-mathcomp-zify`. See jasmin-lang/coqword#15 for the discussion upstream. `coq-mathcomp-algebra-tactics <= 1.0.0` imports `ssrZ` while only qualifying `mathcomp` and not `mathcomp.zify`. This has been fixed in `dev`, but is still a problem for the released packages: https://github.com/math-comp/algebra-tactics/blob/fb87fb0434c17e825b22e3bac9904c8e4f6cd1c2/theories/ring.v#L5 We declare a conflict with `coq-mathcomp-word.2.0` to resolve this.
|
Seems like the failure is due to the usual Dune bug, so merging. |
LasseBlaauwbroek
added a commit
to LasseBlaauwbroek/opam-coq-archive
that referenced
this pull request
Jan 27, 2023
….2.0` Follow up on coq#2452. Conflict for apery is here: https://github.com/coq-community/apery/blob/4239449caf0e2d05bf36a4fb9c42c702b9b9df70/theories/rat_of_Z.v#L3 Conflict for prosa is here: https://gitlab.mpi-sws.org/RT-PROOFS/rt-proofs/-/blob/v0.5/model/priority/gel.v#L4
LasseBlaauwbroek
added a commit
to LasseBlaauwbroek/opam-coq-archive
that referenced
this pull request
Jan 27, 2023
….2.0` Follow up on coq#2452. Conflict for apery is here: https://github.com/coq-community/apery/blob/4239449caf0e2d05bf36a4fb9c42c702b9b9df70/theories/rat_of_Z.v#L3 Conflict for prosa is here: https://gitlab.mpi-sws.org/RT-PROOFS/rt-proofs/-/blob/v0.5/model/priority/gel.v#L4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: These are not my packages
Starting with
coq-mathcomp-word2.0, this package lives in the namespacemathcomp.word, and it includes a filessrZthat conflicts with a corresponding file fromcoq-mathcomp-zify. Seejasmin-lang/coqword#15 for the discussion upstream.
coq-mathcomp-algebra-tactics <= 1.0.0importsssrZwhile only qualifyingmathcompand notmathcomp.zify. This has been fixed indev, but is still a problem for the released packages:https://github.com/math-comp/algebra-tactics/blob/fb87fb0434c17e825b22e3bac9904c8e4f6cd1c2/theories/ring.v#L5
We declare a conflict with
coq-mathcomp-word.2.0to resolve this.