Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable compactor and alertmanager in target all #6204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable compactor and alertmanager in target all #6204

wants to merge 1 commit into from

Conversation

SungJin1212
Copy link
Contributor

What this PR does:
Enable compactor and alertmanager in target all.
Which issue(s) this PR fixes:
Fixes #6098

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@SungJin1212 SungJin1212 force-pushed the Enable-compactor-and-alertmanager-to-all branch from 9cab6ca to 8c62379 Compare September 10, 2024 08:47
@SungJin1212
Copy link
Contributor Author

@friedrichg
Could you please take a look?

@SungJin1212 SungJin1212 force-pushed the Enable-compactor-and-alertmanager-to-all branch from 8c62379 to 6913d2b Compare September 10, 2024 08:50
@SungJin1212
Copy link
Contributor Author

SungJin1212 commented Sep 10, 2024 •
edited
Loading

@friedrichg
I fixing the e2e test now!
In many e2e tests, Alertmanager is not necessary. But, because SingleBinary contains Alertmanager, unnecessary code would be added. How should I handle this?

@SungJin1212 SungJin1212 marked this pull request as draft September 10, 2024 09:38
friedrichg
friedrichg reviewed Sep 10, 2024
View reviewed changes
pkg/cortex/cortex_test.go Outdated
}

externalURL := flagext.URLValue{}
err := externalURL.Set("http://localhost/api/prom")
Copy link
Member

@friedrichg friedrichg Sep 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
err := externalURL.Set("http://localhost/api/prom")
err := externalURL.Set("http://localhost/alertmanager")

it's more appropriate

@friedrichg
Copy link
Member

friedrichg commented Sep 10, 2024 •
edited
Loading

I think you can fix most integration tests adding the following snippet to the yamls in docs/configuration

alertmanager:
  external_url: http://localhost/alertmanager

alertmanager_storage:
  backend: local

or something similar

@SungJin1212 SungJin1212 force-pushed the Enable-compactor-and-alertmanager-to-all branch from 6913d2b to fd5ee03 Compare September 11, 2024 08:37
@pull-request-size pull-request-size bot added size/L and removed size/M labels Sep 11, 2024
@SungJin1212 SungJin1212 marked this pull request as ready for review September 11, 2024 08:54
friedrichg
friedrichg approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@friedrichg friedrichg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't do what I suggested, but that is ok. You solved the problem.
The getting-started is not used in the docs anymore, so more work is needed there. Not to be done in this PR, for sure.

@SungJin1212
Copy link
Contributor Author

@friedrichg
Thank you for the review and suggestion :)

@SungJin1212
Copy link
Contributor Author

@CharlieTLe
Could you please take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@friedrichg friedrichg friedrichg approved these changes

@CharlieTLe CharlieTLe CharlieTLe approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable compactor and alertmanager in target all
3 participants
@SungJin1212 @friedrichg @CharlieTLe