Protobuf Introduction + Types #5491

alexanderbez · 2020-01-07T20:55:25Z

Description

Cleaning up/restructure of Makefile(s)
Addition of buf tooling
Migrating /types to protobuf
- Coin
- DecCoin
- Implement CustomProtoType for Int, Uint, and Dec (to allow gogo proto's customtype)
CI updates

ref: #5444

For contributor use:

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer

For admin use:

Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
Reviewers assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

types/proto.go

aaronc · 2020-01-08T15:22:01Z

buf.yaml

+    - FILE_LOWER_SNAKE_CASE
+  except:
+    - UNARY_RPC
+    - COMMENT_FIELD


I would actually lean towards requiring field comments, but maybe it will make migration slower...

We can, but it'll be super tedious. We don't even do this for standard go types.

aaronc · 2020-01-08T15:22:14Z

buf.yaml

+    - COMMENTS
+    - FILE_LOWER_SNAKE_CASE
+  except:
+    - UNARY_RPC


Do we have any use case for streaming RPC?

No, we don't atm.

types/proto.go

fedekunze

utACK. Pending CI passing

.circleci/config.yml

alexanderbez · 2020-01-13T17:16:49Z

Will wait to get this merged until after v0.38 is released in case we need to get last-minute changes into master.

@aaronc, the change from bytes to string for amount causes build errors and does not work as -is.

.circleci/config.yml

codec/types.go

codec/testdata/animal.go

docs/core/encoding.md

codecov · 2020-01-21T14:23:41Z

Codecov Report

Merging #5491 into master will decrease coverage by 0.41%.
The diff coverage is 44.66%.

@@            Coverage Diff             @@
##           master    #5491      +/-   ##
==========================================
- Coverage   53.42%   53.01%   -0.42%     
==========================================
  Files         316      319       +3     
  Lines       19378    19560     +182     
==========================================
+ Hits        10352    10369      +17     
- Misses       8226     8379     +153     
- Partials      800      812      +12

Impacted Files	Coverage Δ
x/upgrade/module.go	`42.22% <ø> (ø)`	⬆️
x/upgrade/abci.go	`100% <ø> (ø)`	⬆️
x/distribution/types/params.go	`0% <ø> (ø)`	⬆️
store/types/store.go	`43.75% <ø> (ø)`	⬆️
x/staking/abci.go	`50% <ø> (ø)`	⬆️
codec/hybrid_codec.go	`0% <0%> (ø)`
store/prefix/store.go	`86.36% <0%> (-4.12%)`	⬇️
simapp/app.go	`89.5% <0%> (ø)`	⬆️
store/tracekv/store.go	`90.62% <0%> (-2.93%)`	⬇️
store/gaskv/store.go	`72.46% <0%> (-2.17%)`	⬇️
... and 39 more

codec/codec.go

codec/amino_codec_test.go

codec/codec.go

aaronc

Looks good to me. Thanks for all your hard work on this. Excited to get it merged in!

Migrate types to use proto

adfae21

alexanderbez added WIP C:Types T: State Machine Breaking State machine breaking changes (impacts consensus). C:Encoding labels Jan 7, 2020

alexanderbez added 2 commits January 7, 2020 15:56

Add newline

72f70c0

Fix rand_util

80ab9d6

golangcibot reviewed Jan 7, 2020

View reviewed changes

types/proto.go Outdated Show resolved Hide resolved

alexanderbez added 3 commits January 7, 2020 16:06

Add nolint

bf49ef2

Implement amino marshal interface for int, uint, and dec

d9c08cf

Update encoding doc

c5e5c6b

alexanderbez added R4R and removed WIP labels Jan 8, 2020

alexanderbez marked this pull request as ready for review January 8, 2020 15:04

alexanderbez requested review from alessio, fedekunze, jackzampolin and rigelrozanski as code owners January 8, 2020 15:04

alexanderbez added 2 commits January 8, 2020 10:11

Update CircleCI config

c1b17a5

Remove tools target from proto job

28b2da6

aaronc approved these changes Jan 8, 2020

View reviewed changes

alexanderbez and others added 2 commits January 8, 2020 10:32

Rename to CustomProtobufType

f039b99

Merge branch 'master' into bez/5444-types-proto-enc

49aa60d

fedekunze approved these changes Jan 8, 2020

View reviewed changes

Merge branch 'master' into bez/5444-types-proto-enc

cd092c0

alexanderbez commented Jan 8, 2020

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

mircea-c added 3 commits January 8, 2020 15:15

changed proto docker image

b3463f7

changed proto job to skip the binary installs

f05929c

removed extra files and update proto CI

52e0a49

fedekunze mentioned this pull request Jan 9, 2020

Branch for helping review amino protobuf compatibility pr #5143

Closed

alexanderbez added 7 commits January 13, 2020 14:34

Update go.{mod, sum} and install

33400ef

wildcard import

241eafb

Merge branch 'master' into bez/5444-types-proto-enc

489d5e0

go mod tidy

01f7766

Bump cosmos-proto to v0.1.0

bb4ae4e

Update go.{mod, sum}

d6182fb

Update third party proto deps

ba12a87

tac0turtle reviewed Jan 16, 2020

View reviewed changes

.circleci/config.yml Show resolved Hide resolved

sahith-narahari mentioned this pull request Jan 16, 2020

WIP: Add msg_authorization module #5412

Closed

11 tasks

Define Marshaler and ProtoMarshaler interfaces along with BaseCodec type

153dadd

alexanderbez mentioned this pull request Jan 16, 2020

Protobuf: x/auth & x/supply #5533

Merged

12 tasks

aaronc reviewed Jan 16, 2020

View reviewed changes

codec/types.go Outdated Show resolved Hide resolved

alessio mentioned this pull request Jan 17, 2020

Add storeutil module cosmos/modules#24

Closed

Merge branch 'master' into bez/5444-types-proto-enc

3504709

tac0turtle reviewed Jan 20, 2020

View reviewed changes

codec/testdata/animal.go Show resolved Hide resolved

tac0turtle reviewed Jan 20, 2020

View reviewed changes

docs/core/encoding.md Show resolved Hide resolved

Refactor marshaler interface

8bf9d72

Add ProtoCodec tests

790802b

golangcibot reviewed Jan 21, 2020

View reviewed changes

codec/codec.go Outdated Show resolved Hide resolved

codec/amino_codec_test.go Show resolved Hide resolved

codec/amino_codec_test.go Show resolved Hide resolved

codec/amino_codec_test.go Show resolved Hide resolved

alexanderbez added 2 commits January 21, 2020 11:14

Add HybridCodec tests

63ce937

Linting

c123a18

golangcibot reviewed Jan 21, 2020

View reviewed changes

codec/amino_codec_test.go Show resolved Hide resolved

codec/codec.go Outdated Show resolved Hide resolved

alexanderbez and others added 2 commits January 21, 2020 11:48

Merge branch 'master' into bez/5444-types-proto-enc

b35d36d

Update encoding docs

cd6de70

aaronc approved these changes Jan 23, 2020

View reviewed changes

Merge branch 'master' into bez/5444-types-proto-enc

51b5f35

alexanderbez merged commit 26d6e49 into master Jan 24, 2020

tac0turtle deleted the bez/5444-types-proto-enc branch March 4, 2021 15:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Protobuf Introduction + Types #5491

Protobuf Introduction + Types #5491

alexanderbez commented Jan 7, 2020 •

edited

Loading

aaronc Jan 8, 2020

alexanderbez Jan 8, 2020

aaronc Jan 8, 2020

alexanderbez Jan 8, 2020

fedekunze left a comment •

edited

Loading

alexanderbez commented Jan 13, 2020

codecov bot commented Jan 21, 2020 •

edited

Loading

aaronc left a comment

Protobuf Introduction + Types #5491

Protobuf Introduction + Types #5491

Conversation

alexanderbez commented Jan 7, 2020 • edited Loading

Description

aaronc Jan 8, 2020

Choose a reason for hiding this comment

alexanderbez Jan 8, 2020

Choose a reason for hiding this comment

aaronc Jan 8, 2020

Choose a reason for hiding this comment

alexanderbez Jan 8, 2020

Choose a reason for hiding this comment

fedekunze left a comment • edited Loading

Choose a reason for hiding this comment

alexanderbez commented Jan 13, 2020

codecov bot commented Jan 21, 2020 • edited Loading

Codecov Report

aaronc left a comment

Choose a reason for hiding this comment

alexanderbez commented Jan 7, 2020 •

edited

Loading

fedekunze left a comment •

edited

Loading

codecov bot commented Jan 21, 2020 •

edited

Loading