Skip to content

Commit

Permalink
remove pending TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
DimitrisJim committed Apr 23, 2024
1 parent 50eb53f commit 6013514
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions modules/light-clients/08-wasm/depinject.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import (
"cosmossdk.io/core/appmodule"
"cosmossdk.io/core/store"
"cosmossdk.io/depinject"

Check failure on line 6 in modules/light-clients/08-wasm/depinject.go

View workflow job for this annotation

GitHub Actions / lint

File is not `gci`-ed with --skip-generated -s standard -s default -s blank -s dot -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) -s prefix(github.com/cometbft/cometbft) -s prefix(github.com/cosmos/ibc-go) --custom-order (gci)

"github.com/cosmos/cosmos-sdk/codec"
authtypes "github.com/cosmos/cosmos-sdk/x/auth/types"
govtypes "github.com/cosmos/cosmos-sdk/x/gov/types"
Expand Down Expand Up @@ -65,7 +64,7 @@ func ProvideModule(in ModuleInputs) ModuleOutputs {
in.Cdc, in.StoreService, in.ClientKeeper, authority.String(), in.VM, in.QueryRouter, in.Opts...,
)
} else {
// TODO(jim): Check that config is non-nil and panic?
// TODO(jim): If missing, its default value is used. This could very well be surprising and cause misconfiguration
keeper = wasmkeeper.NewKeeperWithConfig(
in.Cdc, in.StoreService, in.ClientKeeper, authority.String(), in.VMConfig, in.QueryRouter, in.Opts...,
)
Expand Down
2 changes: 1 addition & 1 deletion modules/light-clients/08-wasm/testing/simapp/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -662,7 +662,7 @@ func NewSimApp(
mockModule,

// IBC light clients
wasm.NewAppModule(wasmLightClientModule), // TODO(damian): see if we want to pass the lightclient module here, keeper is used in AppModule.RegisterServices etc
wasm.NewAppModule(wasmLightClientModule),
ibctm.NewAppModule(tmLightClientModule),
solomachine.NewAppModule(smLightClientModule),
)
Expand Down

0 comments on commit 6013514

Please sign in to comment.