Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: redundant rpcs #1467

Merged
merged 14 commits into from
Jul 16, 2024
Merged

feat: redundant rpcs #1467

merged 14 commits into from
Jul 16, 2024

Conversation

joelsmith-2019
Copy link
Contributor

@joelsmith-2019 joelsmith-2019 commented Jun 3, 2024 •
edited
Loading

Closes #1198

Adds

  • New config field backup-rpc-addrs to the chain provider configuration
  • CMD rly chains set-backup-rpc-addrs to update config.yaml with backup rpcs
  • Go routine per chain to check for liveliness (every 10s) & cycles when rpc does not respond
  • When adding a chain via the CLI, 2 backup RPCs will be selected from cosmos.directory and defined in the config

Note

  • When RPCs are cycled, the primary takes precedence. Additionally, the backup rpcs will be tried in the order they are configured.
  • When loading a chain configuration from file, backup-rpc-addrs will be picked up as well. Tested locally.

@joelsmith-2019 joelsmith-2019 self-assigned this Jun 3, 2024
@joelsmith-2019 joelsmith-2019 marked this pull request as ready for review June 10, 2024 18:30
@joelsmith-2019 joelsmith-2019 requested a review from a team as a code owner June 10, 2024 18:30
Reecepbcups
Reecepbcups reviewed Jun 11, 2024
View reviewed changes
cmd/chains.go Show resolved Hide resolved
cregistry/chain_info.go Show resolved Hide resolved
cregistry/chain_info.go Show resolved Hide resolved
interchaintest/backup_rpc_test.go Outdated Show resolved Hide resolved
relayer/chain.go Show resolved Hide resolved
relayer/chains/cosmos/provider.go Show resolved Hide resolved
Reecepbcups
Reecepbcups approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@Reecepbcups Reecepbcups left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The forceAdd nit is not as important. Approving so it's not blocked on something small

@Reecepbcups Reecepbcups enabled auto-merge (squash) July 16, 2024 12:40
@Reecepbcups Reecepbcups merged commit c532146 into main Jul 16, 2024
22 checks passed
@Reecepbcups Reecepbcups deleted the joel/backup-rpcs branch July 16, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtieri jtieri jtieri left review comments

@Reecepbcups Reecepbcups Reecepbcups approved these changes

Assignees

@joelsmith-2019 joelsmith-2019

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow multiple RPC's to be defined
3 participants
@joelsmith-2019 @Reecepbcups @jtieri