Skip to content

Commit

Permalink
chore: - release:phase1 from ast plugin (#4430)
Browse files Browse the repository at this point in the history
This causes
https://github.com/coveo/ui-kit/blob/1ba2c94a209c78447e7bd0cde8d1eaab72e15a41/nx.json#L100-L112
to run in the context of packages/rollup-plugin-replace-with-ast, which
does not make sense (and fails because bump is missing in its
package.json, rightfully so)

https://coveord.atlassian.net/browse/KIT-3569

For testing, I nooped most of the release:phase1 script in nx.json,
except the bump itself.
Then, I analyzed the result of the bump to make sure it was sound and
expected.
  • Loading branch information
louis-bompart committed Sep 18, 2024
1 parent b599477 commit e0f85d2
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion packages/rollup-plugin-replace-with-ast/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"private": true,
"$schema": "../../node_modules/nx/schemas/project-schema.json",
"targets": {
"release:phase1": {},
"cached:build": {
"executor": "nx:run-commands",
"options": {
Expand Down

0 comments on commit e0f85d2

Please sign in to comment.