fix(atomic): remove product currency glitch on render #4408
+75
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
y-lakhdar
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fbeaudoincoveo
approved these changes
Sep 13, 2024
|
What's the rationale/explanation relative to the og issue? How is the currency formated then 🤔? |
alexprudhomme
approved these changes
Sep 17, 2024
y-lakhdar
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
y-lakhdar
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
y-lakhdar
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
<atomic-product-numeric-field-value>component from<atomic-product-price>and format the price with the currency directly on the component.Also, moved reusable code in utils/
https://coveord.atlassian.net/browse/KIT-3476