Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo #4792

Merged
merged 11 commits into from
Sep 21, 2024
Merged

typo #4792

merged 11 commits into from
Sep 21, 2024

Conversation

freakin23
Copy link
Contributor

Place an "x" in the corresponding checkbox if it is done or does not apply to this pull request.

  • I have tested my code.
  • I have added my solution according to the steps here.
  • I have followed the code conventions mentioned here.
    • I understand that if it is clear that I have not attempted to follow these conventions, my PR will be closed.
    • If changes are requested, I will re-request a review after addressing them.
  • I have linked this PR to any issues that it closes.

Issue Linked: #4787

@freakin23
Copy link
Contributor Author

@freakin23
Copy link
Contributor Author

Implementation 2 AC (C++): https://cses.fi/paste/f81b53fd18962639a1483b/

@freakin23
Copy link
Contributor Author

I added implementation 2 just in case, if it is unnecessary just tell me I will remove it.

@SansPapyrus683 SansPapyrus683 linked an issue Sep 20, 2024 that may be closed by this pull request
@TheGamingMousse
Copy link
Contributor

@freakin23 so i see that ur PR is a response to this

image

my question is, are you planning on removing the LC problem? cuz rn ur making it so we have two problems that are essentially identical

Copy link
Member

@ryanchou-dev ryanchou-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be helpful to give a brief coverage of the deque method in the module

@freakin23
Copy link
Contributor Author

@freakin23 so i see that ur PR is a response to this

image

my question is, are you planning on removing the LC problem? cuz rn ur making it so we have two problems that are essentially identical

at first i was only paying attention to the subtopic and got some kind of misunderstanding. ig only changing the subtopic would be good.

@freakin23 freakin23 changed the title upd Sliding Window typo Sep 21, 2024
@freakin23
Copy link
Contributor Author

ig now it is good.

@SansPapyrus683 SansPapyrus683 merged commit 5b2edd7 into cpinitiative:master Sep 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sliding Window
4 participants