Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Propagation for labelFiler param #4362

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Propagation for labelFiler param #4362

wants to merge 1 commit into from

Conversation

albfan
Copy link

@albfan albfan commented Sep 20, 2024

Fixes: Issue #4361

Solution/Idea

control filter value encapsulating on double quotes

Testing

integration-tag: "! microshift-preset" should work correctly

Copy link

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign adrianriobo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adrianriobo
Copy link
Contributor

Is this working fine for Windows?

Copy link

openshift-ci bot commented Sep 20, 2024

@albfan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 92753bc link false /test security
ci/prow/integration-crc 92753bc link true /test integration-crc
ci/prow/e2e-crc 92753bc link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants