Task 4 - вроде готов #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8beb916.
This reverts commit 45e2b84.
1) В конструкторе клонируются все поля из переданного ему объекта //Todo Не уверен что так правильно.. стоит еще подумать 2) В set-ре устанавливается поля <=> 1. Поле у объекта существует 2. Значение поля отлично от undefined 3) В get-ре поле вовращается <=> 1. Оно существует у объекта 2. Имя поля имеет тип строку.
Так же освоил тесты на throws
1. Дописал QUnit тесты 2. Перекодировал файлы.. которые забыл перекодировать 3. Рефакторниг. ...... Осталось JSLint and JSDoc
Оказывается UTF8 Без BOM плохо отображается в браузере. А NetBeans - видит символ BOM как отдельный символ
| * @method {filter} - filter elements of current collection and return it | ||
| * @method {sortBy} - sort elements of current collection and return it | ||
| */ | ||
| Collection = function (otherItems) { |
|
Молодец. Кроме пропущенных var и JSDoc претензий больше нет :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.