Enable vpc selector for Route53 Zone
#456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow the instuctions at https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/route53_zone_association ``` Unless explicit association ordering is required (e.g., a separate cross-account association authorization), usage of this resource is not recommended. Use the vpc configuration blocks available within the aws_route53_zone resource instead. ``` and rely on the Zone resource for VPC association * Enable `vpc` section of `Zone` resource * It makes it compliant with community provider-aws HostedZone resource so ease the migration * Document disablement of `route53_vpc_association` resource * Remove `route53_vpc_association` related configuration Signed-off-by: Yury Tsarev <[email protected]>
|
We had an offline discussion with @ytsarev and decided to continue by introducing the |
|
@ulucinar it appeared to be a more tricky situation than we expected. I enabled It failed with According to https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/route53_zone_association , The next obvious question is how to make the zone private. If we look at https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/route53_zone#private-zone the private zone is getting enabled by the inline vpc association. So we have a chicken-egg problem here and it looks like we need both inline and dedicated association styles. |
ytsarev
added a commit
to ytsarev/provider-aws-upbound
that referenced
this pull request
Jan 24, 2023
* Addition to crossplane-contrib#456 * Dedicate `ZoneAssociation` for more complex ZoneToVPC associations for a complex cases * According to investigation documented at crossplane-contrib#456 (comment) we will still need inline `vpc` field to instantiate private Zone first * crossplane-contrib#456 should be merged first so we can ehance `ZoneAssociation` example Signed-off-by: Yury Tsarev <[email protected]>
|
Just opened #463 for dedicated |
1 task
sergenyalcin
approved these changes
Feb 1, 2023
ytsarev
added a commit
to ytsarev/provider-aws-upbound
that referenced
this pull request
Jun 19, 2023
* Addition to crossplane-contrib#456 * Dedicate `ZoneAssociation` for more complex ZoneToVPC associations for a complex cases * According to investigation documented at crossplane-contrib#456 (comment) we will still need inline `vpc` field to instantiate private Zone first * crossplane-contrib#456 should be merged first so we can ehance `ZoneAssociation` example Signed-off-by: Yury Tsarev <[email protected]>
ytsarev
added a commit
to ytsarev/provider-aws-upbound
that referenced
this pull request
Jun 19, 2023
* Addition to crossplane-contrib#456 * Dedicate `ZoneAssociation` for more complex ZoneToVPC associations for a complex cases * According to investigation documented at crossplane-contrib#456 (comment) we will still need inline `vpc` field to instantiate private Zone first * crossplane-contrib#456 should be merged first so we can ehance `ZoneAssociation` example Signed-off-by: Yury Tsarev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Follow the instuctions at https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/route53_zone_association
and rely on the Zone resource for VPC association
vpcsection ofZoneresourceroute53_vpc_associationresourceroute53_vpc_associationrelated configurationSigned-off-by: Yury Tsarev [email protected]
Fixes #392
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested