Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable route53_zone_association #463

Merged
merged 4 commits into from
Jun 22, 2023
Merged

Enable route53_zone_association #463

merged 4 commits into from
Jun 22, 2023

Commits on Jun 19, 2023

  1. Enable route53_zone_association 

    * Addition to crossplane-contrib#456
* Dedicate `ZoneAssociation` for more complex ZoneToVPC associations for
  a complex cases
* According to investigation documented at crossplane-contrib#456 (comment)
  we will still need inline `vpc` field to instantiate private Zone
first
* crossplane-contrib#456 should be merged first so we can ehance `ZoneAssociation` example

Signed-off-by: Yury Tsarev <[email protected]>
    @ytsarev
    ytsarev committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    febb571 View commit details
    Browse the repository at this point in the history

  2. Make zone private in ZoneAssociation example 

    Signed-off-by: Yury Tsarev <[email protected]>
    @ytsarev
    ytsarev committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    7f6f6c4 View commit details
    Browse the repository at this point in the history

  3. Add peer providerconfig to ZoneAssociation example 

    To test as close cross-account scenario as possible

Signed-off-by: Yury Tsarev <[email protected]>
    @ytsarev
    ytsarev committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    be3dd25 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Add VPCAssociationAuthorization 

    Otherwise full cross-account testing of ZoneAssociation will fail with

```
is not authorized to perform: route53:AssociateVPCWithHostedZone on resource: arn:aws:route53:::hostedzone/ZXXX because no resource-based policy allows the route53:AssociateVPCWithHostedZone action
```

Signed-off-by: Yury Tsarev <[email protected]>
    @ytsarev
    ytsarev committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    471c590 View commit details
    Browse the repository at this point in the history