Update LeaderElectionID for Scoped Providers #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ulucinar
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
Thank you @stevendborrelli, lgtm. Please see the comment below.
ulucinar
reviewed
Jun 20, 2023
Signed-off-by: Steven Borrelli <[email protected]>
Signed-off-by: Steven Borrelli <[email protected]>
Signed-off-by: Steven Borrelli <[email protected]>
Signed-off-by: Steven Borrelli <[email protected]>
stevendborrelli
force-pushed
the
leader-election
branch
from
87a264b
to
86fee39
Compare
|
@stevendborrelli can we close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #734
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested locally with iam and eks providers, confirmed that each one uses a family-scoped Leader Election ID and each provider can select a leader: