Set log.Default's output to io.Discard #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if debug logging is not enabled. - Set log.Default's output to io.Discard. Signed-off-by: Alper Rifat Ulucinar <[email protected]>
Signed-off-by: Alper Rifat Ulucinar <[email protected]> (cherry picked from commit 4a1ffb9)
|
/test-examples="examples/pubsub/topic.yaml" |
sergenyalcin
approved these changes
Mar 14, 2024
|
/test-examples="examples/pubsub/topic.yaml" |
…f16b83 Signed-off-by: Alper Rifat Ulucinar <[email protected]>
|
The Uptest Job will fail because of this issue. @ulucinar could you please pin the |
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
|
/test-examples="examples/pubsub/topic.yaml" |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #471
This PR sets a default
io.Discardlogger for the controller-runtime if debug logging is not enabled. If debug logging is enabled, then the controller-runtime uses a debug mode zap logger as usual.It also sets the log.Default's output to io.Discard. According to our experiments with a
Topic.pubsub&ServiceAccount.cloudplatform, this prevents the noisy logs from the underlying Terraform provider. We still need to check for direct log messages via thefmtvariants, such asfmt.Println.In a further iteration, we will also consider making the underlying provider's logs available in a structured format.
Because the various self-hosted runners available for the
upboundGithub organization are not available for thecrossplane-contriborganization, this PR also switches to thestandard-runnersbranch ofupbound/uptestfor the reusable workflows to make the CI jobs run on standard hosted runners.The PR also bumps the build submodule version to commit
75a9fe3ae6b6de82c5f7ddc6a267617940f16b83and pins the UXP version used in uptest runs to1.14.6-up.1. Please see this comment.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested manually with the
Topic.pubsub&ServiceAccount.cloudplatformexample manifests.