tools: move tools.go to its own directory tools/ #382

Rakshith-R · 2023-06-23T10:39:49Z

tools.go is moved to another module tools to
separate all dependencies used for build from
main go.mod.

Rakshith-R · 2023-06-23T11:27:59Z

locally it seems to be working fine,
and all other go build are running fine.

We'll be able to upgrade a lot csiaddons dependencies if we separate operator-sdk out.

@nixpanic any idea why this maybe failing in workflow?

cd ./tools && go build -o /home/runner/work/kubernetes-csi-addons/kubernetes-csi-addons/bin/operator-sdk ./vendor/github.com/operator-framework/operator-sdk/cmd/operator-sdk
go: finding module for package github.com/operator-framework/operator-sdk/internal/cmd/operator-sdk/bundle
go: finding module for package github.com/operator-framework/operator-sdk/internal/cmd/operator-sdk/generate/bundle
go: finding module for package github.com/operator-framework/operator-sdk/internal/cmd/operator-sdk/run/bundle
go: finding module for package github.com/operator-framework/operator-registry/pkg/lib/bundle
Error: vendor/github.com/operator-framework/operator-sdk/internal/registry/labels.go:24:2: cannot query module due to -mod=vendor
	(Go version in go.mod is at least 1.14 and vendor directory exists.)
Error: vendor/github.com/operator-framework/operator-sdk/internal/cmd/operator-sdk/cli/cli.go:39:2: cannot query module due to -mod=vendor
	(Go version in go.mod is at least 1.14 and vendor directory exists.)
Error: vendor/github.com/operator-framework/operator-sdk/internal/cmd/operator-sdk/generate/cmd.go:[20](https://github.com/csi-addons/kubernetes-csi-addons/actions/runs/5355497139/jobs/9713846588?pr=382#step:4:21):2: cannot query module due to -mod=vendor
	(Go version in go.mod is at least 1.14 and vendor directory exists.)
Error: vendor/github.com/operator-framework/operator-sdk/internal/cmd/operator-sdk/run/cmd.go:20:2: cannot query module due to -mod=vendor
	(Go version in go.mod is at least 1.14 and vendor directory exists.)
make: *** [Makefile:[24](https://github.com/csi-addons/kubernetes-csi-addons/actions/runs/5355497139/jobs/9713846588?pr=382#step:4:25)3: operator-sdk] Error 1

nixpanic · 2023-06-23T11:39:19Z

locally it seems to be working fine, and all other go build are running fine.

We'll be able to upgrade a lot csiaddons dependencies if we separate operator-sdk out.

@nixpanic any idea why this maybe failing in workflow?

cd ./tools && go build -o /home/runner/work/kubernetes-csi-addons/kubernetes-csi-addons/bin/operator-sdk ./vendor/github.com/operator-framework/operator-sdk/cmd/operator-sdk
go: finding module for package github.com/operator-framework/operator-sdk/internal/cmd/operator-sdk/bundle
go: finding module for package github.com/operator-framework/operator-sdk/internal/cmd/operator-sdk/generate/bundle
go: finding module for package github.com/operator-framework/operator-sdk/internal/cmd/operator-sdk/run/bundle
go: finding module for package github.com/operator-framework/operator-registry/pkg/lib/bundle
Error: vendor/github.com/operator-framework/operator-sdk/internal/registry/labels.go:24:2: cannot query module due to -mod=vendor
	(Go version in go.mod is at least 1.14 and vendor directory exists.)
Error: vendor/github.com/operator-framework/operator-sdk/internal/cmd/operator-sdk/cli/cli.go:39:2: cannot query module due to -mod=vendor
	(Go version in go.mod is at least 1.14 and vendor directory exists.)
Error: vendor/github.com/operator-framework/operator-sdk/internal/cmd/operator-sdk/generate/cmd.go:[20](https://github.com/csi-addons/kubernetes-csi-addons/actions/runs/5355497139/jobs/9713846588?pr=382#step:4:21):2: cannot query module due to -mod=vendor
	(Go version in go.mod is at least 1.14 and vendor directory exists.)
Error: vendor/github.com/operator-framework/operator-sdk/internal/cmd/operator-sdk/run/cmd.go:20:2: cannot query module due to -mod=vendor
	(Go version in go.mod is at least 1.14 and vendor directory exists.)
make: *** [Makefile:[24](https://github.com/csi-addons/kubernetes-csi-addons/actions/runs/5355497139/jobs/9713846588?pr=382#step:4:25)3: operator-sdk] Error 1

When checking, I noticed this:

$ go mod vendor
go: downloading sigs.k8s.io/controller-runtime/tools/setup-envtest v0.0.0-20230620070423-a784ee78d04b
verifying github.com/operator-framework/[email protected]: checksum mismatch
	downloaded: h1:ZUwkRxMTngafaBtIi8WYEOv2WiI4FsG2UMzKSEgEPPg=
	go.sum:     h1:fHHJd6JkIUWMtQCGfokLZBWYBV7xqFv3JHNSRZzNnjQ=

SECURITY ERROR
This download does NOT match an earlier download recorded in go.sum.
The bits may have been replaced on the origin server, or an attacker may
have intercepted the download attempt.

For more information, see 'go help module-auth'.

After deleting tools/go.sum and running go mod tidy and go mod vendor in the tools/ directory, building operator-sdk works for me (drop the -mod=mod from the Makefile).

nixpanic · 2023-06-23T11:40:35Z

Makefile


 # operator-sdk gets installed from the vendor/ directory.
 OPERATOR_SDK = $(shell pwd)/bin/operator-sdk
 .PHONY: operator-sdk
 operator-sdk:
-	go build -o $(OPERATOR_SDK) ./vendor/$(shell grep operator-sdk tools.go | sed 's/.*_ "//;s/"//')
+	cd ./tools && go build -o $(OPERATOR_SDK) ./vendor/$(shell grep operator-sdk tools/tools.go | sed 's/.*_ "//;s/"//') -mod=mod


remove the -mod=mod

Rakshith-R · 2023-06-23T11:53:51Z

locally it seems to be working fine, and all other go build are running fine.
We'll be able to upgrade a lot csiaddons dependencies if we separate operator-sdk out.
@nixpanic any idea why this maybe failing in workflow?

cd ./tools && go build -o /home/runner/work/kubernetes-csi-addons/kubernetes-csi-addons/bin/operator-sdk ./vendor/github.com/operator-framework/operator-sdk/cmd/operator-sdk
go: finding module for package github.com/operator-framework/operator-sdk/internal/cmd/operator-sdk/bundle
go: finding module for package github.com/operator-framework/operator-sdk/internal/cmd/operator-sdk/generate/bundle
go: finding module for package github.com/operator-framework/operator-sdk/internal/cmd/operator-sdk/run/bundle
go: finding module for package github.com/operator-framework/operator-registry/pkg/lib/bundle
Error: vendor/github.com/operator-framework/operator-sdk/internal/registry/labels.go:24:2: cannot query module due to -mod=vendor
	(Go version in go.mod is at least 1.14 and vendor directory exists.)
Error: vendor/github.com/operator-framework/operator-sdk/internal/cmd/operator-sdk/cli/cli.go:39:2: cannot query module due to -mod=vendor
	(Go version in go.mod is at least 1.14 and vendor directory exists.)
Error: vendor/github.com/operator-framework/operator-sdk/internal/cmd/operator-sdk/generate/cmd.go:[20](https://github.com/csi-addons/kubernetes-csi-addons/actions/runs/5355497139/jobs/9713846588?pr=382#step:4:21):2: cannot query module due to -mod=vendor
	(Go version in go.mod is at least 1.14 and vendor directory exists.)
Error: vendor/github.com/operator-framework/operator-sdk/internal/cmd/operator-sdk/run/cmd.go:20:2: cannot query module due to -mod=vendor
	(Go version in go.mod is at least 1.14 and vendor directory exists.)
make: *** [Makefile:[24](https://github.com/csi-addons/kubernetes-csi-addons/actions/runs/5355497139/jobs/9713846588?pr=382#step:4:25)3: operator-sdk] Error 1

When checking, I noticed this:

$ go mod vendor
go: downloading sigs.k8s.io/controller-runtime/tools/setup-envtest v0.0.0-20230620070423-a784ee78d04b
verifying github.com/operator-framework/[email protected]: checksum mismatch
	downloaded: h1:ZUwkRxMTngafaBtIi8WYEOv2WiI4FsG2UMzKSEgEPPg=
	go.sum:     h1:fHHJd6JkIUWMtQCGfokLZBWYBV7xqFv3JHNSRZzNnjQ=

SECURITY ERROR
This download does NOT match an earlier download recorded in go.sum.
The bits may have been replaced on the origin server, or an attacker may
have intercepted the download attempt.

For more information, see 'go help module-auth'.

After deleting tools/go.sum and running go mod tidy and go mod vendor in the tools/ directory, building operator-sdk works for me (drop the -mod=mod from the Makefile).

Tried the same thing,
Did go clean -modcache too.
switched to mobile hotstop then observed the current compare.

But there's still same failure. https://github.com/csi-addons/kubernetes-csi-addons/actions/runs/5356030502/jobs/9715035090?pr=382
I think there's some problem with my go locally or some network cache problem somewhere
with my ISP.

@nixpanic Can you please run pull this pr, run those changes and force push ?

nixpanic · 2023-06-23T12:02:01Z

Maybe one file under tools/vendor/... was missing, that has been added now.

Rakshith-R · 2023-06-23T12:10:05Z

Thanks !

But it still fails with same error 😩
Bad luck has hit Csiaddons ci 🙁

Rakshith-R · 2023-06-23T13:36:53Z

Makefile

+# FIXME: Remove `go mod tidy && go mod vendor` once we find the reason why ci workflow fails.
+	cd ./tools && go mod tidy && go mod vendor && go build -o $(OPERATOR_SDK) ./vendor/$(shell grep operator-sdk tools/tools.go | sed 's/.*_ "//;s/"//')


Added this to make ci happy .
opened new issue for this #384

Rakshith-R · 2023-06-26T07:04:46Z

@nixpanic @Madhu-1 Can you please take a look?
mergifyio is failing with The pull request reports more than 7900 files, reaching the limit of 1000 files.
We can ignore it.
We need to merge this pr manually.

nixpanic · 2023-06-26T07:30:40Z

@Mergifyio queue

mergify · 2023-06-26T07:31:01Z

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 342d457

tools.go is moved to another module tools to separate all dependencies used for build from main go.mod. Signed-off-by: Rakshith R <[email protected]>

Rakshith-R requested review from nixpanic and Madhu-1 June 23, 2023 10:39

Rakshith-R force-pushed the dir-tools branch from 4c10bfd to fad1416 Compare June 23, 2023 10:48

Rakshith-R force-pushed the dir-tools branch from fad1416 to 1ee3ec2 Compare June 23, 2023 11:33

nixpanic reviewed Jun 23, 2023

View reviewed changes

Rakshith-R force-pushed the dir-tools branch from 1ee3ec2 to 54d2098 Compare June 23, 2023 11:49

nixpanic approved these changes Jun 23, 2023

View reviewed changes

nixpanic force-pushed the dir-tools branch from 54d2098 to ec17cd9 Compare June 23, 2023 11:56

nixpanic approved these changes Jun 23, 2023

View reviewed changes

nixpanic force-pushed the dir-tools branch from ec17cd9 to bd4cd03 Compare June 23, 2023 12:01

subhamkrai mentioned this pull request Jun 23, 2023

build: add golang modules for apis #381

Closed

Rakshith-R force-pushed the dir-tools branch 4 times, most recently from 2b08f6b to a369b39 Compare June 23, 2023 13:33

Rakshith-R mentioned this pull request Jun 23, 2023

FIXME: Remove go mod tidy && go mod vendor once we find the reason why ci workflow fails without it. #384

Open

Rakshith-R commented Jun 23, 2023

View reviewed changes

Madhu-1 approved these changes Jun 26, 2023

View reviewed changes

nixpanic approved these changes Jun 26, 2023

View reviewed changes

tools: move tools.go to its own directory tools/

02d893d

tools.go is moved to another module tools to separate all dependencies used for build from main go.mod. Signed-off-by: Rakshith R <[email protected]>

Rakshith-R force-pushed the dir-tools branch from a369b39 to 02d893d Compare June 26, 2023 07:31

mergify bot merged commit 342d457 into csi-addons:main Jun 26, 2023
12 of 13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tools: move tools.go to its own directory tools/ #382

tools: move tools.go to its own directory tools/ #382

Rakshith-R commented Jun 23, 2023

Rakshith-R commented Jun 23, 2023

nixpanic commented Jun 23, 2023

nixpanic Jun 23, 2023

Rakshith-R commented Jun 23, 2023

nixpanic commented Jun 23, 2023

Rakshith-R commented Jun 23, 2023

Rakshith-R Jun 23, 2023

Rakshith-R commented Jun 26, 2023

nixpanic commented Jun 26, 2023

mergify bot commented Jun 26, 2023 •

edited

Loading

		# FIXME: Remove `go mod tidy && go mod vendor` once we find the reason why ci workflow fails.
		cd ./tools && go mod tidy && go mod vendor && go build -o $(OPERATOR_SDK) ./vendor/$(shell grep operator-sdk tools/tools.go \| sed 's/.*_ "//;s/"//')

tools: move tools.go to its own directory tools/ #382

tools: move tools.go to its own directory tools/ #382

Conversation

Rakshith-R commented Jun 23, 2023

Rakshith-R commented Jun 23, 2023

nixpanic commented Jun 23, 2023

nixpanic Jun 23, 2023

Choose a reason for hiding this comment

Rakshith-R commented Jun 23, 2023

nixpanic commented Jun 23, 2023

Rakshith-R commented Jun 23, 2023

Rakshith-R Jun 23, 2023

Choose a reason for hiding this comment

Rakshith-R commented Jun 26, 2023

nixpanic commented Jun 26, 2023

mergify bot commented Jun 26, 2023 • edited Loading

✅ The pull request has been merged automatically

mergify bot commented Jun 26, 2023 •

edited

Loading