Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workaround for iOS pdf display #73

Merged
merged 1 commit into from
Oct 1, 2023
Merged

fix: workaround for iOS pdf display #73

merged 1 commit into from
Oct 1, 2023

Conversation

VaiTon
Copy link
Member

@VaiTon VaiTon commented Sep 30, 2023

Workaround for #64.

Se vi piace mergiamo, sennò proponete xD

@vercel
Copy link

vercel bot commented Sep 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dynamik ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2023 9:43pm

@lucat1
Copy link
Collaborator

lucat1 commented Oct 1, 2023

Non adoro l'idea perchè questo rompe la navigazione client side su iOS. Idealmente sarebbe meglio usare una libreria tipo pdf.js per svelte.

@VaiTon
Copy link
Member Author

VaiTon commented Oct 1, 2023

@lucat1 neanche a me fa impazzire, ma integrare pdf.js è abbastanza un problema.

Questo, appunto, è un workaround per renderlo funzionante per iOS for the time being.

@lucat1
Copy link
Collaborator

lucat1 commented Oct 1, 2023

si pdf.js è un dito in culo. possiamo accettarlo come workaround ma lascerei la issue aperta

@VaiTon VaiTon merged commit 85480d4 into main Oct 1, 2023
2 checks passed
@VaiTon VaiTon deleted the fix_ios branch October 1, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants