Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support externalising attachments in HTML formatter #2413

Merged
merged 27 commits into from
Aug 12, 2024

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Jul 4, 2024

🤔 What's changed?

  • Updates HTML formatter version (brings in support for externalised attachments, links)
  • Adds option to externalise attachments for HTML formatter, with code to rewrite most attachment messages accordingly if on
    • The exceptions are logs and links, which being short (and with logs potentially numerous) would have little or no value being externalised
  • Adds link function on the world for adding links to URLs as attachments

⚡️ What's your motivation?

The cucumber-js version of both

(These are two different wins for users, but there was enough technical overlap that it made sense to just ship them as one PR.)

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

Coverage Status

coverage: 97.944% (-0.02%) from 97.961%
when pulling 5fdd358 on feat/html-externalise
into 4c67f49 on main.

@coveralls
Copy link

Coverage Status

coverage: 97.944% (-0.02%) from 97.961%
when pulling 2db209b on feat/html-externalise
into 4c67f49 on main.

@coveralls
Copy link

coveralls commented Aug 3, 2024

Coverage Status

coverage: 97.946% (-0.02%) from 97.961%
when pulling 9cfdb2b on feat/html-externalise
into 551efa2 on main.

@davidjgoss davidjgoss merged commit 7ef4d0e into main Aug 12, 2024
10 checks passed
@davidjgoss davidjgoss deleted the feat/html-externalise branch August 12, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants