Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Position #502

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Update Position #502

wants to merge 12 commits into from

Conversation

bam241
Copy link
Member

@bam241 bam241 commented Jun 3, 2019

This follows cyclus/cyclus#1510.

simplifying the call to toolkit::Position

@bam241
Copy link
Member Author

bam241 commented Jun 5, 2019

apparently Position unit tests are missing for XX_insts and YY_regions

@bam241
Copy link
Member Author

bam241 commented Jun 5, 2019

this should not be passing before the corresponding PR is merged in Cyclus (cyclus/cyclus#1510)

@@ -7,7 +7,7 @@ DeployInst::DeployInst(cyclus::Context* ctx)
: cyclus::Institution(ctx),
latitude(0.0),
longitude(0.0),
coordinates(latitude, longitude) {}
coordinates(0,0) {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be updated to match the last commit to the cyclus repo where these are initialized in the header/snippet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

2 participants