prevent underflow when not enough material is available to make a packagable bid #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build Status Report - f3637af - 2024-08-28 13:56:51 -0600Build
|
gonuke
requested changes
Aug 21, 2024
src/source.cc
Outdated
| @@ -103,7 +103,10 @@ std::set<cyclus::BidPortfolio<cyclus::Material>::Ptr> Source::GetMatlBids( | |||
|
|
|||
| // calculate packaging | |||
| double bid_qty = context()->GetPackage(package)->GetFillMass(qty); | |||
| int n_full_bids = static_cast<int>(std::floor(qty / bid_qty)); | |||
| int n_full_bids = 0; | |||
| if (bid_qty >= context()->GetPackage(package)->fill_min()) { | |||
There was a problem hiding this comment.
In mat_sell_policy we only make sure that it's not 0 rather than compare to fill_min. I wonder which one is more robust and more useful?
There was a problem hiding this comment.
Perhaps we should also somehow return n_full_bids from GetFillMass() and handle this in a single robust way?
There was a problem hiding this comment.
Fixing in cyclus#1790
|
I relaunched tests with the updates in cyclus |
|
This also requires cyclus#1795 for the python tests to pass on latest |
|
Now passes on latest - will merge. |
gonuke
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
n_full_bidscould result in negative int max whenbid_qty= 0, when it should be zeroRequires cyclus#1790 to be merged first!(merged)