-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Increase Runtime coverage #5694
Conversation
Closing/Reopening PR because it seems that code coverage was below the previous value, which happens randomly. Given that this PR increases code coverage, this shouldn't happen, so running it again to have a second chance. |
Reopening the PR made all tests to pass the first time, which resulted in a complete code coverage of 88%, which is indeed +2% of code coverage.
But the branch is out of date so I'm going to merge it. Anyway, this PR is good to merge. |
Should we now increase the coverage threshold to 87% ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some warnings are generated for the added code
Was some of the new code generated? Can you comment on why that was needed and how it was generated? |
d8c44eb
to
713c008
Compare
Good question. The code was generated by ChatGPT, and I reviewed it manually (like fixing the warnings you mentioned). Here is the conversation I had with it. Why ChatGPT generation.
I just realized we could simplify the assertions of the length in a loop to reduce the size of the file, which I just did. |
Could you leave a comment describing the generation in the code? That way someone can regenerate it when necessary. |
This PR increases the Runtime coverage by adding more tests to cover previously uncovered lines.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.