Don't complain about determinism for traits #5711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-aws
approved these changes
Aug 19, 2024
dnezam
pushed a commit
to dnezam/dafny
that referenced
this pull request
Sep 21, 2024
### Description After dafny-lang#5632, Dafny started complaining about traits lacking constructors (which they can't have) when `--enforce-determinism` was enabled. This changes back to the previous behavior of warning only about classes without constructors. ### How has this been tested? Updated `dafny0/ForbidNondeterminismResolve.dfy` to include a trait declaration. By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After #5632, Dafny started complaining about traits lacking constructors (which they can't have) when
--enforce-determinismwas enabled. This changes back to the previous behavior of warning only about classes without constructors.How has this been tested?
Updated
dafny0/ForbidNondeterminismResolve.dfyto include a trait declaration.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.