Release 4.8.0 #5733
Merged
Release 4.8.0 #5733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikaelMayer
commented
Aug 29, 2024
atomb
requested changes
Aug 29, 2024
| @@ -93,6 +93,9 @@ update-go-module: | |||
| update-runtime-dafny: | |||
| (cd "${DIR}"; cd Source/DafnyRuntime/DafnyRuntimeDafny; make update-go) | |||
|
|
|||
| update-standard-libraries: | |||
| var exitCode = 1; | ||
| try { | ||
| exitCode = await operand.Execute(inputReader, outputWriter, errorWriter); | ||
| } catch (Win32Exception) { |
There was a problem hiding this comment.
I suspect this exception would be a different one on non-Windows platforms. Or is it used on all platforms in .NET?
There was a problem hiding this comment.
Windows does not have the "rm" command so I'm not sure if the original returns an exception if the file does not exist or not.
There was a problem hiding this comment.
Note: the code was working fine in other platforms without the try catch, so I'm not expecting this to break any other platform.
atomb
previously approved these changes
Aug 30, 2024
|
EDIT: piping the result of @atomb LMK if this works for you |
… order + .doo files updated
|
Changes accepted. |
ssomayyajula
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merging the release 4.8.0 branch into master It brings several modifications that were deemed necessary
%rmwon't fail if a file or a folder does not exist (which is the case the first time)-foption to cp and mv to be able to run the same test multiple timesHow has this been tested?
Tests are passing on the CI and previously offending tests are also passing on my Windows machine.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.