Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Misc Rust runtime improvements #5769

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

alex-chew
Copy link
Contributor

Description

This PR makes the following improvements to the Rust runtime to make it easier to use:

  • Remove unsafe from some Object conversions where we've determined it's not needed
  • Allow rc_struct_to_dafny_class to be used for unsized types
  • Use $crate hygiene in all proc macros (and fully-qualifying some symbols), both to avoid potential name conflicts with consuming code, and also consuming code don't need to manually bring symbols into scope

How has this been tested?

This PR relies on existing tests; no new API features or symbols were added.

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@alex-chew alex-chew marked this pull request as ready for review September 16, 2024 17:03
@alex-chew alex-chew force-pushed the alexchew/misc-rust-runtime-improvements branch from a0a50a5 to b203ca4 Compare September 16, 2024 22:45
@alex-chew alex-chew changed the base branch from feat-rust to master September 16, 2024 22:51
Copy link
Member

@MikaelMayer MikaelMayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the runtime a lot !

@MikaelMayer MikaelMayer enabled auto-merge (squash) September 17, 2024 20:36
@MikaelMayer MikaelMayer merged commit fcdb143 into master Sep 17, 2024
22 checks passed
@MikaelMayer MikaelMayer deleted the alexchew/misc-rust-runtime-improvements branch September 17, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants